mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 00:55:52 +03:00
[PR #1695] Custom HTML at the Top of "<body>" #1807
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#1807
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/tzapu/WiFiManager/pull/1695
Author: @ab-tools
Created: 1/1/2024
Status: 🔄 Open
Base:
master← Head:CustomTopBodyElement📝 Commits (1)
2604230Added setCustomTopBodyElement allowing to define custom HTML to be added at the top of the "" tag.📊 Changes
2 files changed (+17 additions, -2 deletions)
View changed files
📝
WiFiManager.cpp(+11 -0)📝
WiFiManager.h(+6 -2)📄 Description
Added setCustomTopBodyElement allowing to define custom HTML to be added at the top of the "" tag.
This is very useful to add a custom HTML header, e. g. also a logo at the top of the page.
I know this would in general be possible with
WIFI_MANAGER_OVERRIDE_STRINGSand copying the wholewm_strings_en.hfile, however, if the only goal is to add a single line of HTML code at the top of the page this seems like a bad idea:Whenever something would get added in that file, these changes would need to be copied over manually to the custom file again.
Having the option to just "inject" and additional HTML code at the top of the body tag (similar as it is already possible to inject something at the bottom of the "head" tag) seems a much better option.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.