[PR #1692] Make WiFiManagerParameter destructor virtual #1806

New issue

Open

opened 2026-02-28 02:13:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 02:13:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1692
Author: @rguca
Created: 12/28/2023
Status: 🔄 Open

Base: master ← Head: wifi-param-destructor

📝 Commits (1)

ac7c0eb make WiFiManagerParameter destructor virtual

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 WiFiManager.h (+1 -1)

📄 Description

If a instance of WiFiManagerParameter is created by new and deleted by delete, a compiler warning is issued.

src/settings/SettingsController.cpp:78:67: warning: deleting object of polymorphic class type 'WiFiManagerParameter' which has non-virtual destructor might cause undefined behavior [-Wdelete-non-virtual-dtor]
   78 |   for (WiFiManagerParameter* p : this->wifi_settings->parameters) delete p;

The destructor should be virtual, because the class can be extended.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1692 **Author:** [@rguca](https://github.com/rguca) **Created:** 12/28/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `wifi-param-destructor` --- ### 📝 Commits (1) - [`ac7c0eb`](https://github.com/tzapu/WiFiManager/commit/ac7c0eb8eb3907cee93af33801efb8c4c8b75562) make WiFiManagerParameter destructor virtual ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.h` (+1 -1) </details> ### 📄 Description If a instance of WiFiManagerParameter is created by `new` and deleted by `delete`, a compiler warning is issued. ``` src/settings/SettingsController.cpp:78:67: warning: deleting object of polymorphic class type 'WiFiManagerParameter' which has non-virtual destructor might cause undefined behavior [-Wdelete-non-virtual-dtor] 78 | for (WiFiManagerParameter* p : this->wifi_settings->parameters) delete p; ``` The destructor should be virtual, because the class can be extended. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>