[PR #1694] [CLOSED] Remove WM_NO_TEMP compilation warning #1805

Closed
opened 2026-02-28 02:13:04 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1694
Author: @PBrunot
Created: 12/31/2023
Status: Closed

Base: masterHead: remove-warning


📄 Description

WiFiManager always generates a warning on ESP32 due to missing temperature sensor.

With platformio it is not possible to configure the -Wno-cpp flag per library. I want to compile my project with -Wall -Wextra , and having a warning I cannot solve bugs me. I didn't see the point of the warning of the user of the library anyways.

This PR remove the #warning instruction.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1694 **Author:** [@PBrunot](https://github.com/PBrunot) **Created:** 12/31/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `remove-warning` --- ### 📄 Description WiFiManager always generates a warning on ESP32 due to missing temperature sensor. With platformio it is not possible to configure the -Wno-cpp flag per library. I want to compile my project with -Wall -Wextra , and having a warning I cannot solve bugs me. I didn't see the point of the warning of the user of the library anyways. This PR remove the #warning instruction. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 02:13:04 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/WiFiManager#1805
No description provided.