[PR #1637] Limited redirect #1793

Open
opened 2026-02-28 02:13:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1637
Author: @raomin
Created: 7/13/2023
Status: 🔄 Open

Base: masterHead: master


📝 Commits (1)

📊 Changes

1 file changed (+9 additions, -0 deletions)

View changed files

📝 WiFiManager.cpp (+9 -0)

📄 Description

When I connect to wifimanager from my windows, it generates many requests (eg wpad/wpad.dat, autodiscover, etc.).
All these requests end up being served by wifimanager twice: once for redirect and a second time as 404.
It's often so consuming for asyncweb that the esp32 ends up crashing and my pc disconnected.
It's often better from my mobile where I get less extra requests.

However, I believe we shouldn't redirect these extra requests in the first place. With this change, I see no more crashes nor disconnections.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1637 **Author:** [@raomin](https://github.com/raomin) **Created:** 7/13/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`7007fdb`](https://github.com/tzapu/WiFiManager/commit/7007fdb327ded4e1ba20e4bb5b60069fdb3f0af2) Limited redirect ### 📊 Changes **1 file changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+9 -0) </details> ### 📄 Description When I connect to wifimanager from my windows, it generates many requests (eg wpad/wpad.dat, autodiscover, etc.). All these requests end up being served by wifimanager twice: once for redirect and a second time as 404. It's often so consuming for asyncweb that the esp32 ends up crashing and my pc disconnected. It's often better from my mobile where I get less extra requests. However, I believe we shouldn't redirect these extra requests in the first place. With this change, I see no more crashes nor disconnections. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/WiFiManager#1793
No description provided.