[PR #1474] [MERGED] Refactor strings BREAKING #1764

New issue

Closed

opened 2026-02-28 02:12:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 02:12:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1474
Author: @tablatronix
Created: 8/9/2022
Status: ✅ Merged
Merged: 11/28/2022
Merged by: @tablatronix

Base: master ← Head: refactor_strings

📝 Commits (8)

04ef5ed refactor strings, split out consts breaking!
bb9f092 move consts out of strings file BREAKING
a57fabb adds WM_STRINGS_FILE for env overrides
feba026 Revert "move consts out of strings file BREAKING"
14b41c8 Create wm_strings_en.h
218f168 final clean up of strings_en.h, legacy
ba947fd Merge branch 'master' into refactor_strings
651f4b4 comments

📊 Changes

4 files changed (+545 additions, -498 deletions)

View changed files

📝 WiFiManager.h (+8 -2)
📝 strings_en.h (+9 -496)
➕ wm_consts_en.h (+254 -0)
➕ wm_strings_en.h (+274 -0)

📄 Description

This is a possible breaking change if you have modified your strings file.

Constants have been moved to wm_consts_en.h
strings has been renamed to wm_strings_en.h, with shim left in
adds WM_STRINGS_FILE for env override of string asset
strings file MUST include a consts file as it contains localized tokens which are still used for web paths and error msgs and tokens

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1474 **Author:** [@tablatronix](https://github.com/tablatronix) **Created:** 8/9/2022 **Status:** ✅ Merged **Merged:** 11/28/2022 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `master` ← **Head:** `refactor_strings` --- ### 📝 Commits (8) - [`04ef5ed`](https://github.com/tzapu/WiFiManager/commit/04ef5ed1d3a4dc4458aaf969176f4cf4c30fe9cf) refactor strings, split out consts breaking! - [`bb9f092`](https://github.com/tzapu/WiFiManager/commit/bb9f092413153825d8e7acde1dcc1489e840df1e) move consts out of strings file BREAKING - [`a57fabb`](https://github.com/tzapu/WiFiManager/commit/a57fabb215753dcf44aa0b11ccb68dc323375961) adds WM_STRINGS_FILE for env overrides - [`feba026`](https://github.com/tzapu/WiFiManager/commit/feba026c9cf75f510ff6af10ab45fc9b5010163b) Revert "move consts out of strings file BREAKING" - [`14b41c8`](https://github.com/tzapu/WiFiManager/commit/14b41c8085c024fbd6b9ea4ce204168732805160) Create wm_strings_en.h - [`218f168`](https://github.com/tzapu/WiFiManager/commit/218f168734721a2f7a5d248d22036ca3ed9f3806) final clean up of strings_en.h, legacy - [`ba947fd`](https://github.com/tzapu/WiFiManager/commit/ba947fd0ec84496ecc9c5a5acabdfe91c41a4cfb) Merge branch 'master' into refactor_strings - [`651f4b4`](https://github.com/tzapu/WiFiManager/commit/651f4b4b059e887a95ad8f187233ad24b0e8f54d) comments ### 📊 Changes **4 files changed** (+545 additions, -498 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.h` (+8 -2) 📝 `strings_en.h` (+9 -496) ➕ `wm_consts_en.h` (+254 -0) ➕ `wm_strings_en.h` (+274 -0) </details> ### 📄 Description This is a possible breaking change if you have modified your strings file. * Constants have been moved to `wm_consts_en.h` * strings has been renamed to wm_strings_en.h, with shim left in * adds `WM_STRINGS_FILE` for env override of string asset * strings file MUST include a consts file as it contains localized tokens which are still used for web paths and error msgs and tokens --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>