mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 00:55:52 +03:00
[PR #1470] [MERGED] Use esp_wifi_set_country_code for ESP32 #1761
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#1761
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/tzapu/WiFiManager/pull/1470
Author: @thorrak
Created: 8/9/2022
Status: ✅ Merged
Merged: 8/9/2022
Merged by: @tablatronix
Base:
master← Head:setcountry-patch📝 Commits (1)
18de66bUse esp_wifi_set_country_code for ESP32📊 Changes
1 file changed (+10 additions, -7 deletions)
View changed files
📝
WiFiManager.cpp(+10 -7)📄 Description
This pull request replaces the use of
esp_wifi_set_country()withesp_wifi_set_country_code()for ESP32 in order to both solve a crash under Arduino 2.x and remove the requirement to independently maintain country-specific channel settings. In testing on my end, this solves the crash seen in #1309 .One thing of note - I think that
esp_wifi_set_country_code()was only added with the later versions of esp-idf added when Arduino 2.x was released -- I'm not sure if you intend to continue to support the earlier framework, but if you do then some conditional compilation logic may be needed here.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.