[PR #1319] switch handleWiFi to chunkedResponse #1736

Open
opened 2026-02-28 02:12:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1319
Author: @bwjohns4
Created: 12/14/2021
Status: 🔄 Open

Base: masterHead: chunked_handleWiFi_response


📝 Commits (3)

  • c0174e2 switch handleWiFi to chunkedResponse
  • c6d1921 send getParamOut() directly w/o adding to page
  • 38fe638 replace methods with underlying functions

📊 Changes

1 file changed (+12 additions, -2 deletions)

View changed files

📝 WiFiManager.cpp (+12 -2)

📄 Description

This is actually my first PR, hopefully I'm doing this correctly. I was using a lot of parameters and sometimes they were getting dumped out of the response in handleWiFi(). This is how I fixed the issue.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1319 **Author:** [@bwjohns4](https://github.com/bwjohns4) **Created:** 12/14/2021 **Status:** 🔄 Open **Base:** `master` ← **Head:** `chunked_handleWiFi_response` --- ### 📝 Commits (3) - [`c0174e2`](https://github.com/tzapu/WiFiManager/commit/c0174e239b9fd1d4f06a4bcfa957187afad6eeee) switch handleWiFi to chunkedResponse - [`c6d1921`](https://github.com/tzapu/WiFiManager/commit/c6d1921a5a331a49333c9cbc1ec2716327ce49b3) send getParamOut() directly w/o adding to page - [`38fe638`](https://github.com/tzapu/WiFiManager/commit/38fe63819d3f457b85d05c386378add0032333b7) replace methods with underlying functions ### 📊 Changes **1 file changed** (+12 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+12 -2) </details> ### 📄 Description This is actually my first PR, hopefully I'm doing this correctly. I was using a lot of parameters and sometimes they were getting dumped out of the response in handleWiFi(). This is how I fixed the issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/WiFiManager#1736
No description provided.