[PR #1307] [MERGED] Change Stream to Print #1734

New issue

Closed

opened 2026-02-28 02:12:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 02:12:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1307
Author: @pfn
Created: 11/1/2021
Status: ✅ Merged
Merged: 5/8/2022
Merged by: @tablatronix

Base: master ← Head: print-not-stream

📝 Commits (2)

d8e4ece Change Stream to Print 1/2
d800f2a Change Stream to Print 2/2

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 WiFiManager.cpp (+1 -1)
📝 WiFiManager.h (+3 -3)

📄 Description

WifiManager does not use any Stream functionality for _debugPort; change the declaration of _debugPort so that it is more easily used by other implementations.

Personally, I use a ring buffer that implements Print but not Stream for reading.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1307 **Author:** [@pfn](https://github.com/pfn) **Created:** 11/1/2021 **Status:** ✅ Merged **Merged:** 5/8/2022 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `master` ← **Head:** `print-not-stream` --- ### 📝 Commits (2) - [`d8e4ece`](https://github.com/tzapu/WiFiManager/commit/d8e4ece9383165d58fc5a6d8f4ca02b77f596be2) Change Stream to Print 1/2 - [`d800f2a`](https://github.com/tzapu/WiFiManager/commit/d800f2a20f77844cdd3e0642eb4bf7e3fd5e25d2) Change Stream to Print 2/2 ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+1 -1) 📝 `WiFiManager.h` (+3 -3) </details> ### 📄 Description WifiManager does not use any `Stream` functionality for `_debugPort`; change the declaration of `_debugPort` so that it is more easily used by other implementations. Personally, I use a ring buffer that implements Print but not Stream for reading. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>