[PR #1196] [CLOSED] Not saving custom IP and parameters in a certain case. #1725

New issue

Closed

opened 2026-02-28 02:12:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 02:12:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1196
Author: @EgHubs
Created: 1/25/2021
Status: ❌ Closed

Base: development ← Head: patch-1

📝 Commits (2)

1fc2731 Remove branch references
33cfd5a Not saving custom IP and parameters in a certain case.

📊 Changes

2 files changed (+36 additions, -26 deletions)

View changed files

📝 README.md (+3 -4)
📝 examples/AutoConnect/AutoConnectWithFSParametersAndCustomIP/AutoConnectWithFSParametersAndCustomIP.ino (+33 -22)

📄 Description

There is a case that I encountered that causes the ESP parameters and custom IP not to be saved, which happens when the user enters a new WiFi data and parameters at the configuration point and the ESP fails to connect to that WiFi network -which could possibly be a problem related to that router network- so, in that case, I think we should save the WiFi custom IP and user parameters anyway.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1196 **Author:** [@EgHubs](https://github.com/EgHubs) **Created:** 1/25/2021 **Status:** ❌ Closed **Base:** `development` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`1fc2731`](https://github.com/tzapu/WiFiManager/commit/1fc27318d30c53a8315dc30f4ae0553a864a33d3) Remove branch references - [`33cfd5a`](https://github.com/tzapu/WiFiManager/commit/33cfd5aaa5698886f2311b07042369f9def021f0) Not saving custom IP and parameters in a certain case. ### 📊 Changes **2 files changed** (+36 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+3 -4) 📝 `examples/AutoConnect/AutoConnectWithFSParametersAndCustomIP/AutoConnectWithFSParametersAndCustomIP.ino` (+33 -22) </details> ### 📄 Description There is a case that I encountered that causes the ESP parameters and custom IP not to be saved, which happens when the user enters a new WiFi data and parameters at the configuration point and the ESP fails to connect to that WiFi network -which could possibly be a problem related to that router network- so, in that case, I think we should save the WiFi custom IP and user parameters anyway. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>