[PR #1151] [MERGED] Use constrain properly #1716

New issue

Closed

opened 2026-02-28 02:12:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 02:12:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1151
Author: @lbussy
Created: 11/22/2020
Status: ✅ Merged
Merged: 11/22/2020
Merged by: @tablatronix

Base: development ← Head: development

📝 Commits (2)

5def8f8 Use constrain properly
3a66412 Merge pull request #1 from brewpi-remix/fix-constrain

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 WiFiManager.cpp (+1 -2)

📄 Description

As written, the way constrain is used has no effect/unintended effect and will generate the following warnings:

warning: second operand of conditional expression has no effect [-Wunused-value]
warning: third operand of conditional expression has no effect [-Wunused-value]

This change addresses those warnings and corrects the behavior.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1151 **Author:** [@lbussy](https://github.com/lbussy) **Created:** 11/22/2020 **Status:** ✅ Merged **Merged:** 11/22/2020 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `development` ← **Head:** `development` --- ### 📝 Commits (2) - [`5def8f8`](https://github.com/tzapu/WiFiManager/commit/5def8f84d4559998fc68bbc5f6be65ef324229b9) Use constrain properly - [`3a66412`](https://github.com/tzapu/WiFiManager/commit/3a66412db4fed6504e07f2f4ba463e216d1574a0) Merge pull request #1 from brewpi-remix/fix-constrain ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+1 -2) </details> ### 📄 Description As written, the way constrain is used has no effect/unintended effect and will generate the following warnings: ``` warning: second operand of conditional expression has no effect [-Wunused-value] warning: third operand of conditional expression has no effect [-Wunused-value] ``` This change addresses those warnings and corrects the behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>