[PR #1130] [CLOSED] Fix iteration over ID-less Parameters; add update method to Parameters #1713

New issue

Closed

opened 2026-02-28 02:12:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 02:12:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/1130
Author: @Lithimlin
Created: 9/21/2020
Status: ❌ Closed

Base: master ← Head: development

📝 Commits (7)

fb22787 Fix ID-less params handling, update WiFiManagerParameter
c37c2f7 remove HEADs
148880d make operator= for Parameters private again
8ceeba2 Rebase update including:
21cffa5 remove HEADs
e3e2058 make operator= for Parameters private again
355346a Update from original repo

📊 Changes

2 files changed (+258 additions, -152 deletions)

View changed files

📝 WiFiManager.cpp (+197 -101)
📝 WiFiManager.h (+61 -51)

📄 Description

This pull request contains the following changes:

Turn break statements into continue statements in WiFiManager.cpp (fixes #1116)
Add virtual update method for Parameters (to allow for things like #1113)
Also some (a lot of) whitespace changes my editor automatically did that shouldn't change anything though

I understand if the update method is not wanted. In that case just let me know.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/1130 **Author:** [@Lithimlin](https://github.com/Lithimlin) **Created:** 9/21/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `development` --- ### 📝 Commits (7) - [`fb22787`](https://github.com/tzapu/WiFiManager/commit/fb22787b541c34eb4566e3b7a48bca7d682df15d) Fix ID-less params handling, update WiFiManagerParameter - [`c37c2f7`](https://github.com/tzapu/WiFiManager/commit/c37c2f7ff642bc59162880d389e439f823b7a57b) remove HEADs - [`148880d`](https://github.com/tzapu/WiFiManager/commit/148880d289645e72fed543216e5a5c9ababe5227) make operator= for Parameters private again - [`8ceeba2`](https://github.com/tzapu/WiFiManager/commit/8ceeba2f1e5fdecdd0e754dcecccef6e16e1011f) Rebase update including: - [`21cffa5`](https://github.com/tzapu/WiFiManager/commit/21cffa513270bc310d834a7aeac50d9f0b3b2dfd) remove HEADs - [`e3e2058`](https://github.com/tzapu/WiFiManager/commit/e3e205865eb6cacdb7d7273f3808b387f80d11b0) make operator= for Parameters private again - [`355346a`](https://github.com/tzapu/WiFiManager/commit/355346ad0fa9c048f46bf260aa0cbacaa9922584) Update from original repo ### 📊 Changes **2 files changed** (+258 additions, -152 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+197 -101) 📝 `WiFiManager.h` (+61 -51) </details> ### 📄 Description This pull request contains the following changes: * Turn break statements into continue statements in `WiFiManager.cpp` (fixes #1116) * Add virtual update method for Parameters (to allow for things like #1113) * Also some (a lot of) whitespace changes my editor automatically did that shouldn't change anything though I understand if the update method is not wanted. In that case just let me know. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>