[PR #803] [MERGED] wifimanager.cpp / wifimanager.h #1686

New issue

Closed

opened 2026-02-28 02:12:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 02:12:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/803
Author: @sidey79
Created: 1/8/2019
Status: ✅ Merged
Merged: 2/14/2019
Merged by: @tablatronix

Base: development ← Head: define-hardware

📝 Commits (1)

1282c4d wifimanager.cpp / wifimanager.h

📊 Changes

2 files changed (+9 additions, -0 deletions)

View changed files

📝 WiFiManager.cpp (+4 -0)
📝 WiFiManager.h (+5 -0)

📄 Description

I figured out, that there is no check on the hardware plattform, which is currently selected.
There are serval plattforms, which does not compile, i suggest adding a if defined check to the preprocessor.

Why is this useful?

I've a multi plattform Project. I used two seprerate source code projects in the past, but now i want to merge them. When i try to compile my project with an AVR Board, it fails, because it trys to compile the wifi lib but doesn't find serval used libs.

-added define that checks on esp32 or esp8266. If another hardware is selectec, then do not try to compile this code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/803 **Author:** [@sidey79](https://github.com/sidey79) **Created:** 1/8/2019 **Status:** ✅ Merged **Merged:** 2/14/2019 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `development` ← **Head:** `define-hardware` --- ### 📝 Commits (1) - [`1282c4d`](https://github.com/tzapu/WiFiManager/commit/1282c4d5b520e447b51cbd9d107a72048b28724d) wifimanager.cpp / wifimanager.h ### 📊 Changes **2 files changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+4 -0) 📝 `WiFiManager.h` (+5 -0) </details> ### 📄 Description I figured out, that there is no check on the hardware plattform, which is currently selected. There are serval plattforms, which does not compile, i suggest adding a if defined check to the preprocessor. Why is this useful? I've a multi plattform Project. I used two seprerate source code projects in the past, but now i want to merge them. When i try to compile my project with an AVR Board, it fails, because it trys to compile the wifi lib but doesn't find serval used libs. -added define that checks on esp32 or esp8266. If another hardware is selectec, then do not try to compile this code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>