[PR #681] [CLOSED] Fix custom html from out of scope #1664

New issue

Closed

opened 2026-02-28 02:12:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 02:12:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/681
Author: @liebman
Created: 7/28/2018
Status: ❌ Closed

Base: development ← Head: fix_custom_html_from_out_of_scope

📝 Commits (2)

126000e over eager "parameter out of scope"
728e1f8 _customHTML is by default an empty string so its NULL or first char is '\0'

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 WiFiManager.cpp (+1 -1)

📄 Description

Over eager "parameter out of scope" check:
Custom html was triggering "parameter out of scope" as its length was 0 causing parameters not to be added. In my case I have a "label" (custom html) first and none of my 31 parameters were showing up.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/681 **Author:** [@liebman](https://github.com/liebman) **Created:** 7/28/2018 **Status:** ❌ Closed **Base:** `development` ← **Head:** `fix_custom_html_from_out_of_scope` --- ### 📝 Commits (2) - [`126000e`](https://github.com/tzapu/WiFiManager/commit/126000e625edfc552ce1a3c56a46b60e1a84979d) over eager "parameter out of scope" - [`728e1f8`](https://github.com/tzapu/WiFiManager/commit/728e1f89e2f1bafa9cdf65c8a494a5a6cdd22cfc) _customHTML is by default an empty string so its NULL or first char is '\0' ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+1 -1) </details> ### 📄 Description Over eager "parameter out of scope" check: Custom html was triggering "parameter out of scope" as its length was 0 causing parameters not to be added. In my case I have a "label" (custom html) first and none of my 31 parameters were showing up. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>