[PR #683] [MERGED] Hotfixes #1663

New issue

Closed

opened 2026-02-28 02:12:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 02:12:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/683
Author: @ldab
Created: 8/3/2018
Status: ✅ Merged
Merged: 8/5/2018
Merged by: @tablatronix

Base: master ← Head: hotfixes

📝 Commits (4)

d27fa7d hotfixing #425
0f2ba75 Update AutoConnectWithFSParameters.ino
40d522d Merge pull request #649 from vincentVDB/patch-1
704a7ae hotfix WPS NO_EXTRA_4K_HEAP

📊 Changes

2 files changed (+17 additions, -3 deletions)

View changed files

📝 WiFiManager.cpp (+16 -3)
📝 examples/AutoConnectWithFSParameters/AutoConnectWithFSParameters.ino (+1 -0)

📄 Description

Add

WiFiManagerParameter::WiFiManagerParameter(const char *id, int length, const char *custom) {
  _id = id;
  _placeholder = NULL;
  _length = length;
  _value = NULL;

  _customHTML = custom;
}

This way #L522 to:

if (_params[i]->getValue() != NULL) {

Would allow to use custom HTML as and drop-down list for example. Because originally _id = NULL; this line [#L598] won't retrieve value from the drop-down list. screenshot_20180803-230205_chrome 🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/683 **Author:** [@ldab](https://github.com/ldab) **Created:** 8/3/2018 **Status:** ✅ Merged **Merged:** 8/5/2018 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `master` ← **Head:** `hotfixes` --- ### 📝 Commits (4) - [`d27fa7d`](https://github.com/tzapu/WiFiManager/commit/d27fa7df618e7eaad7f54e26aec635e274dc2224) hotfixing #425 - [`0f2ba75`](https://github.com/tzapu/WiFiManager/commit/0f2ba754e2499e04c4d48d1ef00b488ae68f5778) Update AutoConnectWithFSParameters.ino - [`40d522d`](https://github.com/tzapu/WiFiManager/commit/40d522d8b6aed741ee9d99abc14376ce9b28ec6c) Merge pull request #649 from vincentVDB/patch-1 - [`704a7ae`](https://github.com/tzapu/WiFiManager/commit/704a7ae393e8b8f820a73924d0480aae85781c26) hotfix WPS NO_EXTRA_4K_HEAP ### 📊 Changes **2 files changed** (+17 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+16 -3) 📝 `examples/AutoConnectWithFSParameters/AutoConnectWithFSParameters.ino` (+1 -0) </details> ### 📄 Description Add ``` WiFiManagerParameter::WiFiManagerParameter(const char *id, int length, const char *custom) { _id = id; _placeholder = NULL; _length = length; _value = NULL; _customHTML = custom; } ``` This way [#L522](https://github.com/tzapu/WiFiManager/blob/32495668d8ac691d72ec77b5e423c6f8d3d845b7/WiFiManager.cpp#L522) to: ``` if (_params[i]->getValue() != NULL) { ``` Would allow to use custom HTML as <select> and drop-down list for example. Because originally ``` _id = NULL; ``` this line [[#L598]](https://github.com/tzapu/WiFiManager/blob/32495668d8ac691d72ec77b5e423c6f8d3d845b7/WiFiManager.cpp#L598) won't retrieve value from the drop-down list. [screenshot_20180803-230205_chrome](https://user-images.githubusercontent.com/34199302/43639883-db1e6d0a-9771-11e8-8c96-13a5bbcca5e9.jpg) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>