[PR #645] [MERGED] disable wps by default, enable if its enabled in core #1655

New issue

Closed

opened 2026-02-28 02:12:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 02:12:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/645
Author: @liebman
Created: 7/7/2018
Status: ✅ Merged
Merged: 7/7/2018
Merged by: @tablatronix

Base: development ← Head: only_support_wps_if_no_extra_4k_heap_defined

📝 Commits (1)

5a06f29 In https://github.com/esp8266/Arduino/pull/4889 the core was modified to

📊 Changes

2 files changed (+8 additions, -1 deletions)

View changed files

📝 WiFiManager.cpp (+4 -1)
📝 WiFiManager.h (+4 -0)

📄 Description

In https://github.com/esp8266/Arduino/pull/4889 the core was modified to disable WPS by default. Its only enabled if NO_EXTRA_4K_HEAP is defined. To enable you must re-run the board generator with --noextra4kheap. This adds #ifdef NO_EXTRA_4K_HEAP around WPS usage so it won't generate compiler errors.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/645 **Author:** [@liebman](https://github.com/liebman) **Created:** 7/7/2018 **Status:** ✅ Merged **Merged:** 7/7/2018 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `development` ← **Head:** `only_support_wps_if_no_extra_4k_heap_defined` --- ### 📝 Commits (1) - [`5a06f29`](https://github.com/tzapu/WiFiManager/commit/5a06f29c5b96b973aa5a8e2ecaa5192d01abab3d) In https://github.com/esp8266/Arduino/pull/4889 the core was modified to ### 📊 Changes **2 files changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+4 -1) 📝 `WiFiManager.h` (+4 -0) </details> ### 📄 Description In https://github.com/esp8266/Arduino/pull/4889 the core was modified to disable WPS by default. Its only enabled if NO_EXTRA_4K_HEAP is defined. To enable you must re-run the board generator with --noextra4kheap. This adds #ifdef NO_EXTRA_4K_HEAP around WPS usage so it won't generate compiler errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>