[PR #505] [MERGED] Bug fix for problem discovered when setting length to 1 for additiona… #1634

New issue

Closed

opened 2026-02-28 01:30:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/505
Author: @LaurentLouf
Created: 2/6/2018
Status: ✅ Merged
Merged: 2/6/2018
Merged by: @tablatronix

Base: master ← Head: master

📝 Commits (1)

6aaa83a Bug fix for problem discovered when setting length to 1 for additional parameters

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 WiFiManager.cpp (+2 -2)

📄 Description

…l parameters

The initialization of the buffer holding the value stopped before the last character and storage did not take into account the extra-byte for end of string.

Bug is pretty easy to reproduce : try to use an additional parameter with a length of 1. This PR fixes it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/505 **Author:** [@LaurentLouf](https://github.com/LaurentLouf) **Created:** 2/6/2018 **Status:** ✅ Merged **Merged:** 2/6/2018 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`6aaa83a`](https://github.com/tzapu/WiFiManager/commit/6aaa83a266348ac4accab79c77aeb903d2e3de96) Bug fix for problem discovered when setting length to 1 for additional parameters ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+2 -2) </details> ### 📄 Description …l parameters The initialization of the buffer holding the value stopped before the last character and storage did not take into account the extra-byte for end of string. Bug is pretty easy to reproduce : try to use an additional parameter with a length of 1. This PR fixes it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>