[PR #468] [MERGED] WiFiManagerParameter allocates but never frees __value! #1626

New issue

Closed

opened 2026-02-28 01:30:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/468
Author: @liebman
Created: 12/9/2017
Status: ✅ Merged
Merged: 1/30/2018
Merged by: @tablatronix

Base: master ← Head: param-value-memory-leak

📝 Commits (2)

a5ff5cb Add WiFiManagerParameter destructor to free new'd _value, it was allocated but never free'd
5c6252f should use delete[] not delete

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 WiFiManager.cpp (+6 -0)
📝 WiFiManager.h (+1 -0)

📄 Description

The WiFiManagerParameter constructor allocates _value via new but has no destructor to free via delete.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/468 **Author:** [@liebman](https://github.com/liebman) **Created:** 12/9/2017 **Status:** ✅ Merged **Merged:** 1/30/2018 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `master` ← **Head:** `param-value-memory-leak` --- ### 📝 Commits (2) - [`a5ff5cb`](https://github.com/tzapu/WiFiManager/commit/a5ff5cb9e4bffeb841b3d5e172bd4f408a690f9a) Add WiFiManagerParameter destructor to free new'd _value, it was allocated but never free'd - [`5c6252f`](https://github.com/tzapu/WiFiManager/commit/5c6252fe45144a6fcd5d67cc9c47e27fde33daa2) should use delete[] not delete ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+6 -0) 📝 `WiFiManager.h` (+1 -0) </details> ### 📄 Description The WiFiManagerParameter constructor allocates _value via new but has no destructor to free via delete. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>