[PR #467] [MERGED] Document that parameter id cannot contain spaces #1625

New issue

Closed

opened 2026-02-28 01:30:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/467
Author: @lukepalmer
Created: 12/5/2017
Status: ✅ Merged
Merged: 1/31/2018
Merged by: @tablatronix

Base: master ← Head: master

📝 Commits (1)

eb56062 Document parameters

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 WiFiManager.h (+4 -0)

📄 Description

It took me a while to figure out that custom parameters don't work if there is a space in the id parameter. It's not particularly useful to make this work, so just document that it doesn't.

The reason it doesn't work: the client will use the id parameter as the name of the field in the HTTP GET request that goes back to the server. Spaces and other special characters will get encoded, so "Blynk token" becomes "Blynk+token". The server doesn't do any kind of decoding so it gets confused and thinks the parameter just isn't there.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/467 **Author:** [@lukepalmer](https://github.com/lukepalmer) **Created:** 12/5/2017 **Status:** ✅ Merged **Merged:** 1/31/2018 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`eb56062`](https://github.com/tzapu/WiFiManager/commit/eb560629d6c22f8e77a2b6aed94a9143d596447f) Document parameters ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.h` (+4 -0) </details> ### 📄 Description It took me a while to figure out that custom parameters don't work if there is a space in the id parameter. It's not particularly useful to make this work, so just document that it doesn't. The reason it doesn't work: the client will use the id parameter as the name of the field in the HTTP GET request that goes back to the server. Spaces and other special characters will get encoded, so "Blynk token" becomes "Blynk+token". The server doesn't do any kind of decoding so it gets confused and thinks the parameter just isn't there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>