[PR #313] [MERGED] Development and cleanup #1605

New issue

Closed

opened 2026-02-28 01:30:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/313
Author: @tablatronix
Created: 2/9/2017
Status: ✅ Merged
Merged: 1/17/2018
Merged by: @tablatronix

Base: development ← Head: development

📝 Commits (10+)

83c271f initial commit, signal meter and secure icons
6708ddf remove debug
fd27cef remove debug
74bccc0 adds better retina support
7360be5 Merge remote-tracking branch 'refs/remotes/origin/feature_308_configportaltimeouts'
c8455f5 Merge remote-tracking branch 'refs/remotes/tzapu/master'
9c72bf9 cleaning up source, comments
45a325b fix validippassword
2edd37e oops typo
c819d46 allow for empty password

📊 Changes

12 files changed (+1435 additions, -351 deletions)

View changed files

📝 README.md (+13 -10)
📝 WiFiManager.cpp (+884 -268)
📝 WiFiManager.h (+103 -27)
📝 examples/AutoConnectWithFSParameters/AutoConnectWithFSParameters.ino (+1 -1)
📝 examples/AutoConnectWithFSParametersAndCustomIP/AutoConnectWithFSParametersAndCustomIP.ino (+1 -1)
📝 examples/AutoConnectWithTimeout/AutoConnectWithTimeout.ino (+1 -1)
➕ examples/AutoConnectWithTimeout/platformio.ini (+18 -0)
📝 examples/OnDemandConfigPortal/OnDemandConfigPortal.ino (+5 -2)
➕ examples/OnDemandWebPortal/OnDemandWebPortal.ino (+57 -0)
📝 extras/WiFiManager.template.html (+176 -41)
➕ extras/png_signal_strength_master.png (+0 -0)
➕ extras/test.html (+176 -0)

📄 Description

cleaning up a bit, better comments, some questions @todo, improved some debug messages.
abstracted appassword check, and made fatal, not fallback to anonymous.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/313 **Author:** [@tablatronix](https://github.com/tablatronix) **Created:** 2/9/2017 **Status:** ✅ Merged **Merged:** 1/17/2018 **Merged by:** [@tablatronix](https://github.com/tablatronix) **Base:** `development` ← **Head:** `development` --- ### 📝 Commits (10+) - [`83c271f`](https://github.com/tzapu/WiFiManager/commit/83c271fed49bdbd7fd8846908c699ff15872fcb7) initial commit, signal meter and secure icons - [`6708ddf`](https://github.com/tzapu/WiFiManager/commit/6708ddf37bc51a40fa86509486f9f4ae82a63867) remove debug - [`fd27cef`](https://github.com/tzapu/WiFiManager/commit/fd27cef1aeb11fce552f791794dfb41dff1de3b1) remove debug - [`74bccc0`](https://github.com/tzapu/WiFiManager/commit/74bccc04f73e816794b804729ef017b0c5a44afb) adds better retina support - [`7360be5`](https://github.com/tzapu/WiFiManager/commit/7360be5f609e27a8506482e072ff4f7b4eb7d639) Merge remote-tracking branch 'refs/remotes/origin/feature_308_configportaltimeouts' - [`c8455f5`](https://github.com/tzapu/WiFiManager/commit/c8455f5cd0f531f147a2b224e8e44019fa433ffb) Merge remote-tracking branch 'refs/remotes/tzapu/master' - [`9c72bf9`](https://github.com/tzapu/WiFiManager/commit/9c72bf98f778d38d6da1b4729ad5318318ba86e4) cleaning up source, comments - [`45a325b`](https://github.com/tzapu/WiFiManager/commit/45a325bd3440cfb55f620a985098ab695d3ecb46) fix validippassword - [`2edd37e`](https://github.com/tzapu/WiFiManager/commit/2edd37eeb83dbce93be9d7aecb5308db190e17df) oops typo - [`c819d46`](https://github.com/tzapu/WiFiManager/commit/c819d469022a42f0ac26f368eaa9faf131e26c72) allow for empty password ### 📊 Changes **12 files changed** (+1435 additions, -351 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+13 -10) 📝 `WiFiManager.cpp` (+884 -268) 📝 `WiFiManager.h` (+103 -27) 📝 `examples/AutoConnectWithFSParameters/AutoConnectWithFSParameters.ino` (+1 -1) 📝 `examples/AutoConnectWithFSParametersAndCustomIP/AutoConnectWithFSParametersAndCustomIP.ino` (+1 -1) 📝 `examples/AutoConnectWithTimeout/AutoConnectWithTimeout.ino` (+1 -1) ➕ `examples/AutoConnectWithTimeout/platformio.ini` (+18 -0) 📝 `examples/OnDemandConfigPortal/OnDemandConfigPortal.ino` (+5 -2) ➕ `examples/OnDemandWebPortal/OnDemandWebPortal.ino` (+57 -0) 📝 `extras/WiFiManager.template.html` (+176 -41) ➕ `extras/png_signal_strength_master.png` (+0 -0) ➕ `extras/test.html` (+176 -0) </details> ### 📄 Description cleaning up a bit, better comments, some questions `@todo`, improved some debug messages. abstracted appassword check, and made fatal, not fallback to anonymous. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>