[PR #286] [MERGED] Don't add custom parameters if array size is exceeded #1600

New issue

Closed

opened 2026-02-28 01:30:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/286
Author: @vyruz1986
Created: 1/8/2017
Status: ✅ Merged
Merged: 2/2/2017
Merged by: @tzapu

Base: master ← Head: master

📝 Commits (1)

1f500fd Don't add custom parameters if array size is exceeded

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 WiFiManager.cpp (+8 -0)

📄 Description

array containing custom parameters is initialised at class
initialization time with a fixed value. When we later try to add more
parameters than the array allows we will now discard the offending
parameters and make a debug logging so the developer knows what's going
on.

Might be further improved as per this answer on StackOverflow:
http://stackoverflow.com/a/12271501
This would allow the array size to be specified at initialisation time,
and would give flexibility to the developer to decide how big the array
should be.

closes tzapu/WiFiManager#285

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/286 **Author:** [@vyruz1986](https://github.com/vyruz1986) **Created:** 1/8/2017 **Status:** ✅ Merged **Merged:** 2/2/2017 **Merged by:** [@tzapu](https://github.com/tzapu) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`1f500fd`](https://github.com/tzapu/WiFiManager/commit/1f500fddd1348daffcc27b61f1e53a2f3fbc611d) Don't add custom parameters if array size is exceeded ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+8 -0) </details> ### 📄 Description array containing custom parameters is initialised at class initialization time with a fixed value. When we later try to add more parameters than the array allows we will now discard the offending parameters and make a debug logging so the developer knows what's going on. Might be further improved as per this answer on StackOverflow: http://stackoverflow.com/a/12271501 This would allow the array size to be specified at initialisation time, and would give flexibility to the developer to decide how big the array should be. closes tzapu/WiFiManager#285 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>