[PR #168] [MERGED] Improve comments for AutoConnectWithStaticIP example #1588

New issue

Closed

opened 2026-02-28 01:30:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/168
Author: @gitgrimbo
Created: 5/11/2016
Status: ✅ Merged
Merged: 5/24/2016
Merged by: @tzapu

Base: master ← Head: staticip-example-improved-comments

📝 Commits (1)

c93cd80 Improve comments for AutoConnectWithStaticIP example

📊 Changes

1 file changed (+12 additions, -7 deletions)

View changed files

📝 examples/AutoConnectWithStaticIP/AutoConnectWithStaticIP.ino (+12 -7)

📄 Description

It seems that the first block of code has to be used in my case (using ESP8266 core v2.2.0).

Using the second block seems to cause a silent failure at runtime.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/168 **Author:** [@gitgrimbo](https://github.com/gitgrimbo) **Created:** 5/11/2016 **Status:** ✅ Merged **Merged:** 5/24/2016 **Merged by:** [@tzapu](https://github.com/tzapu) **Base:** `master` ← **Head:** `staticip-example-improved-comments` --- ### 📝 Commits (1) - [`c93cd80`](https://github.com/tzapu/WiFiManager/commit/c93cd80f58fe49941dc24fdefa47fd68cafa4481) Improve comments for AutoConnectWithStaticIP example ### 📊 Changes **1 file changed** (+12 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `examples/AutoConnectWithStaticIP/AutoConnectWithStaticIP.ino` (+12 -7) </details> ### 📄 Description It seems that the first block of code _has_ to be used in my case (using ESP8266 core v2.2.0). Using the second block seems to cause a silent failure at runtime. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>