[PR #157] [CLOSED] Major Functionality Change To Improve Reliability #1587

New issue

Closed

opened 2026-02-28 01:30:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/157
Author: @kentaylor
Created: 4/24/2016
Status: ❌ Closed

Base: pull-request-kentaylor ← Head: master

📝 Commits (10+)

faf307c Merge remote-tracking branch 'refs/remotes/tzapu/master'
2767950 add remove duplicate ap feature fixes #26
745c3a9 typo, shrug
8f5171c Added ability to call StartConfigPortal() so that access point name can be unique and automatically generated from the ESP8266 Chip Id.
852d90b travis ci
f9cc4b6 added boards manager
d11c763 update travis yml
413b76c Merge pull request #124 from tablatronix/remove-duplicate-aps
f99156e added setter for removing duplicate APs
3bb5fad There has been an assumption that device has to be told to connect but Wifi already does it's best to connect in the background. Calling WiFi.begin while device is already trying to connect will occasionally cause WiFi to lock up. Only call WiFi.begin after calling WiFi.disconnect. These changes are aimed at stopping WiFi.begin from being called at the wrong time.

📊 Changes

24 files changed (+1286 additions, -1130 deletions)

View changed files

➕ .travis.yml (+34 -0)
➕ Images/ConfigurationScreen.png (+0 -0)
➕ Images/DefaultScreen.png (+0 -0)
📝 README.md (+163 -195)
📝 WiFiManager.cpp (+435 -189)
📝 WiFiManager.h (+43 -18)
➖ examples/AutoConnect/AutoConnect.ino (+0 -38)
➖ examples/AutoConnectWithFSParameters/AutoConnectWithFSParameters.ino (+0 -156)
➖ examples/AutoConnectWithFSParametersAndCustomIP/AutoConnectWithFSParametersAndCustomIP.ino (+0 -188)
➖ examples/AutoConnectWithFeedback/AutoConnectWithFeedback.ino (+0 -47)
➖ examples/AutoConnectWithFeedbackLED/AutoConnectWithFeedbackLED.ino (+0 -68)
➖ examples/AutoConnectWithReset/AutoConnectWithReset.ino (+0 -49)
➖ examples/AutoConnectWithStaticIP/AutoConnectWithStaticIP.ino (+0 -75)
➖ examples/AutoConnectWithTimeout/AutoConnectWithTimeout.ino (+0 -45)
➕ examples/ConfigOnDoubleReset/ConfigOnDoubleReset.ino (+107 -0)
➕ examples/ConfigOnDoubleReset/README.md (+15 -0)
➕ examples/ConfigOnStartup/ConfigOnStartup.ino (+70 -0)
➕ examples/ConfigOnSwitch/ConfigOnSwitch.ino (+96 -0)
➕ examples/ConfigOnSwitch/README.md (+12 -0)
➕ examples/ConfigOnSwitchFS/ConfigOnSwitchFS.ino (+258 -0)

...and 4 more files

📄 Description

The WiFiManager library has been unreliable for me.

I think this is due to the incorrect premise that the ESP8266 should be instructed to connect to a WiFi network. This has led to the library including unneeded functionality which has the side effect of causing the ESP8266 module to intermittently fail to connect to WiFi, behave inconsistently and occasionally brick.

If this pull request is accepted the library functionality will be substantially changed and it would be included into sketches in a different way.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/157 **Author:** [@kentaylor](https://github.com/kentaylor) **Created:** 4/24/2016 **Status:** ❌ Closed **Base:** `pull-request-kentaylor` ← **Head:** `master` --- ### 📝 Commits (10+) - [`faf307c`](https://github.com/tzapu/WiFiManager/commit/faf307c7bba85c6fd10c2b92e79f16363faccf4b) Merge remote-tracking branch 'refs/remotes/tzapu/master' - [`2767950`](https://github.com/tzapu/WiFiManager/commit/276795079e2f463837e51689b05bc5f8b99acf4f) add remove duplicate ap feature fixes #26 - [`745c3a9`](https://github.com/tzapu/WiFiManager/commit/745c3a91fd94e0748aed051b543b9c9fd0a5eb48) typo, shrug - [`8f5171c`](https://github.com/tzapu/WiFiManager/commit/8f5171cca475fd2f4ec3aa1d56dfb0173514775e) Added ability to call StartConfigPortal() so that access point name can be unique and automatically generated from the ESP8266 Chip Id. - [`852d90b`](https://github.com/tzapu/WiFiManager/commit/852d90beec0ec6122e063a2971b23a06f0af8537) travis ci - [`f9cc4b6`](https://github.com/tzapu/WiFiManager/commit/f9cc4b641feaf872f1dc18e71b520e80c9751fe8) added boards manager - [`d11c763`](https://github.com/tzapu/WiFiManager/commit/d11c763bcef09585483d43a47d818d64db52127d) update travis yml - [`413b76c`](https://github.com/tzapu/WiFiManager/commit/413b76cd81fc809e06db1b80c3723440e4401393) Merge pull request #124 from tablatronix/remove-duplicate-aps - [`f99156e`](https://github.com/tzapu/WiFiManager/commit/f99156e29ff8f1e46c81cf52f5e77f26591a7f9c) added setter for removing duplicate APs - [`3bb5fad`](https://github.com/tzapu/WiFiManager/commit/3bb5fad6534b30e0a1f4e6138c746c828d4d820a) There has been an assumption that device has to be told to connect but Wifi already does it's best to connect in the background. Calling WiFi.begin while device is already trying to connect will occasionally cause WiFi to lock up. Only call WiFi.begin after calling WiFi.disconnect. These changes are aimed at stopping WiFi.begin from being called at the wrong time. ### 📊 Changes **24 files changed** (+1286 additions, -1130 deletions) <details> <summary>View changed files</summary> ➕ `.travis.yml` (+34 -0) ➕ `Images/ConfigurationScreen.png` (+0 -0) ➕ `Images/DefaultScreen.png` (+0 -0) 📝 `README.md` (+163 -195) 📝 `WiFiManager.cpp` (+435 -189) 📝 `WiFiManager.h` (+43 -18) ➖ `examples/AutoConnect/AutoConnect.ino` (+0 -38) ➖ `examples/AutoConnectWithFSParameters/AutoConnectWithFSParameters.ino` (+0 -156) ➖ `examples/AutoConnectWithFSParametersAndCustomIP/AutoConnectWithFSParametersAndCustomIP.ino` (+0 -188) ➖ `examples/AutoConnectWithFeedback/AutoConnectWithFeedback.ino` (+0 -47) ➖ `examples/AutoConnectWithFeedbackLED/AutoConnectWithFeedbackLED.ino` (+0 -68) ➖ `examples/AutoConnectWithReset/AutoConnectWithReset.ino` (+0 -49) ➖ `examples/AutoConnectWithStaticIP/AutoConnectWithStaticIP.ino` (+0 -75) ➖ `examples/AutoConnectWithTimeout/AutoConnectWithTimeout.ino` (+0 -45) ➕ `examples/ConfigOnDoubleReset/ConfigOnDoubleReset.ino` (+107 -0) ➕ `examples/ConfigOnDoubleReset/README.md` (+15 -0) ➕ `examples/ConfigOnStartup/ConfigOnStartup.ino` (+70 -0) ➕ `examples/ConfigOnSwitch/ConfigOnSwitch.ino` (+96 -0) ➕ `examples/ConfigOnSwitch/README.md` (+12 -0) ➕ `examples/ConfigOnSwitchFS/ConfigOnSwitchFS.ino` (+258 -0) _...and 4 more files_ </details> ### 📄 Description The WiFiManager library has been unreliable for me. I think this is due to the incorrect premise that the ESP8266 should be instructed to connect to a WiFi network. This has led to the library including unneeded functionality which has the side effect of causing the ESP8266 module to intermittently fail to connect to WiFi, behave inconsistently and occasionally brick. If this pull request is accepted the library functionality will be substantially changed and it would be included into sketches in a different way. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>