[PR #119] Fix non saving #1581

New issue

Open

opened 2026-02-28 01:30:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/119
Author: @richardwilliamson
Created: 3/6/2016
Status: 🔄 Open

Base: master ← Head: fix-non-saving

📝 Commits (10+)

6a5b2be give option for static OR dynamic
7efbc28 fixed issue with not working after manual portal
b5f41e0 blah
295d7ac Merge remote-tracking branch 'tzapu/master' into fix-non-saving
083d8cb Method to pre-pop wifi fields
0c28ef8 general network and update
3a464a4 Merge remote-tracking branch 'tzapu/master' into fix-non-saving
9450d94 tidied conflicts
5954ee0 allow settings to be updated on page load
261ff8b tidying

📊 Changes

2 files changed (+363 additions, -65 deletions)

View changed files

📝 WiFiManager.cpp (+300 -62)
📝 WiFiManager.h (+63 -3)

📄 Description

Added a WiFi.disconnect() if we are using DHCP which seems to fix the
problem with wifi not connecting when using a manually called portal.
Also added an option to force a save (and exit) even if the wifi
doesn’t connect - this is useful if using on a device away from the
network that it will be eventually used on

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/119 **Author:** [@richardwilliamson](https://github.com/richardwilliamson) **Created:** 3/6/2016 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-non-saving` --- ### 📝 Commits (10+) - [`6a5b2be`](https://github.com/tzapu/WiFiManager/commit/6a5b2beccade984da541158965912d133d69f9f7) give option for static OR dynamic - [`7efbc28`](https://github.com/tzapu/WiFiManager/commit/7efbc28e83078f49f8891c3c30280e0af11e1dac) fixed issue with not working after manual portal - [`b5f41e0`](https://github.com/tzapu/WiFiManager/commit/b5f41e0ac44dce1935e80651545f01a09ec0d233) blah - [`295d7ac`](https://github.com/tzapu/WiFiManager/commit/295d7aca5555214204ce779748e30fb1dfa9bcd1) Merge remote-tracking branch 'tzapu/master' into fix-non-saving - [`083d8cb`](https://github.com/tzapu/WiFiManager/commit/083d8cb7227f2ae3fc45770c3b2e729d85f8d0c5) Method to pre-pop wifi fields - [`0c28ef8`](https://github.com/tzapu/WiFiManager/commit/0c28ef86d9550687878bf3b97387f71bb6446188) general network and update - [`3a464a4`](https://github.com/tzapu/WiFiManager/commit/3a464a44966c06877c45f7ab9698db21155b66d7) Merge remote-tracking branch 'tzapu/master' into fix-non-saving - [`9450d94`](https://github.com/tzapu/WiFiManager/commit/9450d94114dafdc057ef3609424a694c992a0d99) tidied conflicts - [`5954ee0`](https://github.com/tzapu/WiFiManager/commit/5954ee0588657f20ea3f68e3976fd6c9ecbb02c3) allow settings to be updated on page load - [`261ff8b`](https://github.com/tzapu/WiFiManager/commit/261ff8b76e5bd78256b142254cfddbeef664dea9) tidying ### 📊 Changes **2 files changed** (+363 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+300 -62) 📝 `WiFiManager.h` (+63 -3) </details> ### 📄 Description Added a WiFi.disconnect() if we are using DHCP which seems to fix the problem with wifi not connecting when using a manually called portal. Also added an option to force a save (and exit) even if the wifi doesn’t connect - this is useful if using on a device away from the network that it will be eventually used on --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>