mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 00:55:52 +03:00
[PR #55] [MERGED] Added parameter to callback #1568
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#1568
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/tzapu/WiFiManager/pull/55
Author: @franklinvv
Created: 1/9/2016
Status: ✅ Merged
Merged: 1/11/2016
Merged by: @tzapu
Base:
master← Head:master📝 Commits (1)
c77e9cbTo show the config portal SSID in the callback, a global reference to the WiFiManager object was needed. To solve this, a pointer to the WiFiManager object is now passed to the callback. The feedback example is edited accordingly.📊 Changes
3 files changed (+7 additions, -11 deletions)
View changed files
📝
WiFiManager.cpp(+2 -2)📝
WiFiManager.h(+2 -2)📝
examples/AutoConnectWithFeedback/AutoConnectWithFeedback.ino(+3 -7)📄 Description
To show the config portal SSID in the callback, a global reference to the WiFiManager object was needed. To solve this, a pointer to the WiFiManager object is now passed to the callback. The feedback example is edited accordingly.
This does break backward compatibility though, but saves memory.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.