[PR #55] [MERGED] Added parameter to callback #1568

Closed
opened 2026-02-28 01:30:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/tzapu/WiFiManager/pull/55
Author: @franklinvv
Created: 1/9/2016
Status: Merged
Merged: 1/11/2016
Merged by: @tzapu

Base: masterHead: master


📝 Commits (1)

  • c77e9cb To show the config portal SSID in the callback, a global reference to the WiFiManager object was needed. To solve this, a pointer to the WiFiManager object is now passed to the callback. The feedback example is edited accordingly.

📊 Changes

3 files changed (+7 additions, -11 deletions)

View changed files

📝 WiFiManager.cpp (+2 -2)
📝 WiFiManager.h (+2 -2)
📝 examples/AutoConnectWithFeedback/AutoConnectWithFeedback.ino (+3 -7)

📄 Description

To show the config portal SSID in the callback, a global reference to the WiFiManager object was needed. To solve this, a pointer to the WiFiManager object is now passed to the callback. The feedback example is edited accordingly.

This does break backward compatibility though, but saves memory.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/tzapu/WiFiManager/pull/55 **Author:** [@franklinvv](https://github.com/franklinvv) **Created:** 1/9/2016 **Status:** ✅ Merged **Merged:** 1/11/2016 **Merged by:** [@tzapu](https://github.com/tzapu) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`c77e9cb`](https://github.com/tzapu/WiFiManager/commit/c77e9cbcc9e2ac35889efe339fc1caba11e286b2) To show the config portal SSID in the callback, a global reference to the WiFiManager object was needed. To solve this, a pointer to the WiFiManager object is now passed to the callback. The feedback example is edited accordingly. ### 📊 Changes **3 files changed** (+7 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `WiFiManager.cpp` (+2 -2) 📝 `WiFiManager.h` (+2 -2) 📝 `examples/AutoConnectWithFeedback/AutoConnectWithFeedback.ino` (+3 -7) </details> ### 📄 Description To show the config portal SSID in the callback, a global reference to the WiFiManager object was needed. To solve this, a pointer to the WiFiManager object is now passed to the callback. The feedback example is edited accordingly. This does break backward compatibility though, but saves memory. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 01:30:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/WiFiManager#1568
No description provided.