[GH-ISSUE #1733] Force remove DNS input from Captive portal #1468

New issue

Open

opened 2026-02-28 01:30:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:30:12 +03:00

Owner

Originally created by @JuniorLopasso on GitHub (Apr 10, 2024).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1733

Basic Infos

Hardware

WiFimanager Branch/Release: Master

Esp8266/Esp32: Esp32

Hardware: ESP32-WROOM-32-D

Core Version: 2.0.14

Description

I needed to inherit the Wifimanager class in my project and saw a problem when I tried to force the IP fields to be disabled.

On line 2968 of the WiFiManager.cpp file, I think someone forgot to add an “else” statement at the beginning of the line.

It is:
_staShowDns = alwaysShow? 1: 0;

and it should be:
else _staShowDns = alwaysShow? 1: 0;

I hope I helped you with this.

Settings in IDE

Module: NodeMcu

Additional libraries:
knolleary/PubSubClient@^2.8
bblanchon/ArduinoJson@^6.21.2

Sketch

---

Debug Messages

---

Originally created by @JuniorLopasso on GitHub (Apr 10, 2024). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1733 ### Basic Infos #### Hardware WiFimanager Branch/Release: Master Esp8266/Esp32: Esp32 Hardware: ESP32-WROOM-32-D Core Version: 2.0.14 ### Description I needed to inherit the Wifimanager class in my project and saw a problem when I tried to force the IP fields to be disabled. On line 2968 of the WiFiManager.cpp file, I think someone forgot to add an “else” statement at the beginning of the line. It is: `_staShowDns = alwaysShow? 1: 0;` and it should be: `else _staShowDns = alwaysShow? 1: 0;` I hope I helped you with this. ### Settings in IDE Module: NodeMcu Additional libraries: knolleary/PubSubClient@^2.8 bblanchon/ArduinoJson@^6.21.2 ### Sketch ``` --- ``` ### Debug Messages ``` --- ```