mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 00:55:52 +03:00
[GH-ISSUE #1717] Avoid compiler warning. Wrong specifier used for printf statement. #1457
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#1457
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @HenkHoldijk on GitHub (Mar 3, 2024).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1717
Compiling for the ESP32-C3 using the Arduino IDE 1.8.19 results in a compiler warning for WiFiManager.cpp on line 3368.
Original line : "_debugPort.printf("[MEM] free: %5d | max: %5d | frag: %3d%% \n", free, max, frag);"
The %5d does not match the uint32_t free type.
Replace with : "_debugPort.printf("[MEM] free: %5ld | max: %5d | frag: %3d%% \n", free, max, frag);"
@tablatronix commented on GitHub (Mar 3, 2024):
Hmm I would think free and max should be the same type also
@tablatronix commented on GitHub (Mar 3, 2024):
github.com/espressif/arduino-esp32@aed7b4fa59/cores/esp32/chip-debug-report.cpp (L25)@HenkHoldijk commented on GitHub (Mar 3, 2024):
Agree regarding the max. The frag is OK.
Currently they are declared as:
uint32_t free = info.total_free_bytes;
uint16_t max = info.largest_free_block;
uint8_t frag = 100 - (max * 100) / free;
Should be:
uint32_t free = info.total_free_bytes;
uint32_t max = info.largest_free_block;
uint8_t frag = 100 - (max * 100) / free;
The printf then becomes : _debugPort.printf("[MEM] free: %5ld | max: %5ld | frag: %3d%% \n", free, max, frag);