mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 00:55:52 +03:00
[GH-ISSUE #1629] Enable temp support for ESP32-S3 #1389
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#1389
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @roleroz on GitHub (Jun 19, 2023).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1629
PLEASE TRY Latest Master BRANCH before submitting bugs, in case they were already fixed.
Issues without basic info will be ignored or closed!
Please fill the info fields, it helps to get you faster support ;)
if you have a stack dump decode it:
https://github.com/esp8266/Arduino/blob/master/doc/Troubleshooting/stack_dump.rst
for better debug messages:
https://github.com/esp8266/Arduino/blob/master/doc/Troubleshooting/debugging.rst
----------------------------- Remove above -----------------------------
Basic Infos
Hardware
WiFimanager Branch/Release: Master
Esp8266/Esp32: ESP32-S3-devkitc-1 (although it should apply to all ESP32-S3 boards and modules)
Hardware: ESP32-S3
Core Version: v5.0.1 esp-idf, head at WifiManager
Description
Problem description
Temperature sensor in ESP32-S3 is disabled when defining WM_NOTEMP in
github.com/tzapu/WiFiManager@3a303eeb45/WiFiManager.h (L56)When ESP32-S3 was released, there wasn't any support for the temperature sensor APIs for that module, so the WM_NOTEMP macro was introduced to disable any temperature support in WM. Since August last year (i.e. starting with esp-idf v4.4, https://github.com/espressif/arduino-esp32/pull/6994), the support for the temperature sensor APIs has been added to the S3's support
Given this, we should re-enable temperature sensor support for the S3 when using a v4.4 or newer instance of esp-idf
Settings in IDE
Any settings will create this, as the temperature sensor disabling is hardcoded in the code
Sketch
Debug Messages
@roleroz commented on GitHub (Nov 2, 2023):
Any news on this one?