mirror of
https://github.com/tzapu/WiFiManager.git
synced 2026-04-27 00:55:52 +03:00
[GH-ISSUE #1589] wifiManager.setConfigPortalTimeout should only time out if no client connected to AP #1354
Labels
No labels
📶 WiFi
🕸️ HTTP
Branch
DEV Help Wanted
Discussion
Documentation
ESP32
Example
Good First Issue
Hotfix
In Progress
Incomplete
Needs Feeback
Priority
QA
Question
Task
Upstream/Dependancy
bug
duplicate
enhancement
invalid
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/WiFiManager#1354
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @probonopd on GitHub (Apr 16, 2023).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1589
E.g., when we set a 180 seconds timeout like this:
wifiManager.setConfigPortalTimeout(180);The 180 seconds timeout should be t for the user to connect to the access point and open the configuration portal. Once the user has connected to the access point and opened the configuration portal, the user should be able to take as much time as they need to enter the WiFi credentials and save them (not just 180 seconds).
Or is that already the case?
@Catta1997 commented on GitHub (Apr 20, 2023):
I think that it wait, since the description say "Check for connection and if it's still not established do whatever is needed" but im not 100% sure. You can also use
setConfigPortalBlocking(boolean shouldBlock), but as description say user is responsible for closing configportal.@tablatronix commented on GitHub (Apr 23, 2023):
The timer is reset everytime an http connection is made, but I agree you could timeout on that page filling out params..
I guess we could add some background XHR keepalive, or you can use the apclientcheck , but sometimes it stays showing a client so is not enabled.