[GH-ISSUE #1574] Should the name 'wm_consts_en.h' be changed to 'wm_consts_string.h' ? #1343

New issue

Open

opened 2026-02-28 01:29:40 +03:00 by kerem · 1 comment

kerem commented

2026-02-28 01:29:40 +03:00

Owner

Originally created by @georgevbsantiago on GitHub (Mar 19, 2023).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1574

The example of 'wm_strings_es.h' with the Spanish translation has been added. Very good! Thank you very much for your work!!!

Just a question. Is it necessary to create a 'wm_consts_es.h' too? Is it allowed to change words in 'wm_consts_en.h' ?

Ex:

const char * const _menutokens[_nummenutokens] PROGMEM = {
...
     "erase",
...
};

Change to:

const char * const _menutokens[_nummenutokens] PROGMEM = {
...
     "borrar",
...
};

If not recommended, wouldn't it be better to change the name from 'wm_consts_en.h' to 'wm_consts_string.h' ?

If you keep the name 'wm_consts_en.h', the user can understand that the information in the file must be translated as well. What do you think?

Originally created by @georgevbsantiago on GitHub (Mar 19, 2023). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1574 The example of 'wm_strings_es.h' with the Spanish translation has been added. Very good! Thank you very much for your work!!! Just a question. Is it necessary to create a 'wm_consts_es.h' too? Is it allowed to change words in 'wm_consts_en.h' ? Ex: ``` const char * const _menutokens[_nummenutokens] PROGMEM = { ... "erase", ... }; ``` Change to: ``` const char * const _menutokens[_nummenutokens] PROGMEM = { ... "borrar", ... }; ``` If not recommended, wouldn't it be better to change the name from 'wm_consts_en.h' to 'wm_consts_string.h' ? If you keep the name 'wm_consts_en.h', the user can understand that the information in the file must be translated as well. What do you think?

kerem commented

2026-02-28 01:29:41 +03:00

Author

Owner

@tablatronix commented on GitHub (Mar 19, 2023):

Consts can be changed but are usually not needed or exposed to end users.
But they can be Just do the same copy and change the name and include from the es file

@tablatronix commented on GitHub (Mar 19, 2023): Consts can be changed but are usually not needed or exposed to end users. But they can be Just do the same copy and change the name and include from the es file