[GH-ISSUE #1570] cosmetic move WM_DEBUG_LEVEL inside DEBUG_WM #1340

New issue

Open

opened 2026-02-28 01:29:40 +03:00 by kerem · 3 comments

kerem commented

2026-02-28 01:29:40 +03:00

Owner

Originally created by @dontsovcmc on GitHub (Mar 2, 2023).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1570

Can't understand why I need add WM_DEBUG_LEVEL everywhere near DEBUG_WM.

We should write something like this:

#ifdef WM_DEBUG_LEVEL
template <typename Generic>
void WiFiManager::DEBUG_WM(Generic text) {
  DEBUG_WM(DEBUG_NOTIFY,text,"");
}

template <typename Generic>
void WiFiManager::DEBUG_WM(wm_debuglevel_t level,Generic text) {
  if(_debugLevel >= level) DEBUG_WM(level,text,"");
}

template <typename Generic, typename Genericb>
void WiFiManager::DEBUG_WM(Generic text,Genericb textb) {
  DEBUG_WM(DEBUG_NOTIFY,text,textb);
}

template <typename Generic, typename Genericb>
void WiFiManager::DEBUG_WM(wm_debuglevel_t level,Generic text,Genericb textb) {
  if(!_debug || _debugLevel < level) return;

  if(_debugLevel >= DEBUG_MAX){
    #ifdef ESP8266
    // uint32_t free;
    // uint16_t max;
    // uint8_t frag;
    // ESP.getHeapStats(&free, &max, &frag);// @todo Does not exist in 2.3.0
    // _debugPort.printf("[MEM] free: %5d | max: %5d | frag: %3d%% \n", free, max, frag); 
    #elif defined ESP32
    // total_free_bytes;      ///<  Total free bytes in the heap. Equivalent to multi_free_heap_size().
    // total_allocated_bytes; ///<  Total bytes allocated to data in the heap.
    // largest_free_block;    ///<  Size of largest free block in the heap. This is the largest malloc-able size.
    // minimum_free_bytes;    ///<  Lifetime minimum free heap size. Equivalent to multi_minimum_free_heap_size().
    // allocated_blocks;      ///<  Number of (variable size) blocks allocated in the heap.
    // free_blocks;           ///<  Number of (variable size) free blocks in the heap.
    // total_blocks;          ///<  Total number of (variable size) blocks in the heap.
    multi_heap_info_t info;
    heap_caps_get_info(&info, MALLOC_CAP_INTERNAL);
    uint32_t free = info.total_free_bytes;
    uint16_t max  = info.largest_free_block;
    uint8_t frag = 100 - (max * 100) / free;
    _debugPort.printf("[MEM] free: %5d | max: %5d | frag: %3d%% \n", free, max, frag);    
    #endif
  }
  _debugPort.print(_debugPrefix);
  if(_debugLevel >= debugLvlShow) _debugPort.print("["+(String)level+"] ");
  _debugPort.print(text);
  if(textb){
    _debugPort.print(" ");
    _debugPort.print(textb);
  }
  _debugPort.println();
}
#else
template <typename Generic>
void WiFiManager::DEBUG_WM(Generic text) {}

template <typename Generic>
void WiFiManager::DEBUG_WM(wm_debuglevel_t level,Generic text) {}

template <typename Generic, typename Genericb>
void WiFiManager::DEBUG_WM(Generic text,Genericb textb) {}

template <typename Generic, typename Genericb>
void WiFiManager::DEBUG_WM(wm_debuglevel_t level,Generic text,Genericb textb) {}
#endif

Originally created by @dontsovcmc on GitHub (Mar 2, 2023). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1570 Can't understand why I need add WM_DEBUG_LEVEL everywhere near DEBUG_WM. We should write something like this: ```C++ #ifdef WM_DEBUG_LEVEL template <typename Generic> void WiFiManager::DEBUG_WM(Generic text) { DEBUG_WM(DEBUG_NOTIFY,text,""); } template <typename Generic> void WiFiManager::DEBUG_WM(wm_debuglevel_t level,Generic text) { if(_debugLevel >= level) DEBUG_WM(level,text,""); } template <typename Generic, typename Genericb> void WiFiManager::DEBUG_WM(Generic text,Genericb textb) { DEBUG_WM(DEBUG_NOTIFY,text,textb); } template <typename Generic, typename Genericb> void WiFiManager::DEBUG_WM(wm_debuglevel_t level,Generic text,Genericb textb) { if(!_debug || _debugLevel < level) return; if(_debugLevel >= DEBUG_MAX){ #ifdef ESP8266 // uint32_t free; // uint16_t max; // uint8_t frag; // ESP.getHeapStats(&free, &max, &frag);// @todo Does not exist in 2.3.0 // _debugPort.printf("[MEM] free: %5d | max: %5d | frag: %3d%% \n", free, max, frag); #elif defined ESP32 // total_free_bytes; ///< Total free bytes in the heap. Equivalent to multi_free_heap_size(). // total_allocated_bytes; ///< Total bytes allocated to data in the heap. // largest_free_block; ///< Size of largest free block in the heap. This is the largest malloc-able size. // minimum_free_bytes; ///< Lifetime minimum free heap size. Equivalent to multi_minimum_free_heap_size(). // allocated_blocks; ///< Number of (variable size) blocks allocated in the heap. // free_blocks; ///< Number of (variable size) free blocks in the heap. // total_blocks; ///< Total number of (variable size) blocks in the heap. multi_heap_info_t info; heap_caps_get_info(&info, MALLOC_CAP_INTERNAL); uint32_t free = info.total_free_bytes; uint16_t max = info.largest_free_block; uint8_t frag = 100 - (max * 100) / free; _debugPort.printf("[MEM] free: %5d | max: %5d | frag: %3d%% \n", free, max, frag); #endif } _debugPort.print(_debugPrefix); if(_debugLevel >= debugLvlShow) _debugPort.print("["+(String)level+"] "); _debugPort.print(text); if(textb){ _debugPort.print(" "); _debugPort.print(textb); } _debugPort.println(); } #else template <typename Generic> void WiFiManager::DEBUG_WM(Generic text) {} template <typename Generic> void WiFiManager::DEBUG_WM(wm_debuglevel_t level,Generic text) {} template <typename Generic, typename Genericb> void WiFiManager::DEBUG_WM(Generic text,Genericb textb) {} template <typename Generic, typename Genericb> void WiFiManager::DEBUG_WM(wm_debuglevel_t level,Generic text,Genericb textb) {} #endif ```

kerem added the

enhancement

Good First Issue

labels

2026-02-28 01:29:40 +03:00

kerem commented

2026-02-28 01:29:40 +03:00

Author

Owner

@tablatronix commented on GitHub (Mar 3, 2023):

Cause I have not gotten to refactoring yet, i thought there was an issue for this..

Could probably even be a template template

I assume the compiler will optimize this out entirely ? I was not sure and have not checked best practices for this yet

@tablatronix commented on GitHub (Mar 3, 2023): Cause I have not gotten to refactoring yet, i thought there was an issue for this.. Could probably even be a template template I assume the compiler will optimize this out entirely ? I was not sure and have not checked best practices for this yet

kerem commented

2026-02-28 01:29:40 +03:00

Author

Owner

@dontsovcmc commented on GitHub (Mar 3, 2023):

Maybe you have "refactoring" issue to write down easy changes?

I found additional "small" enhancement:

HTTPSend copies content variable

void WiFiManager::HTTPSend(String content){
  server->send(200, FPSTR(HTTP_HEAD_CT), content);
}

right way:

void WiFiManager::HTTPSend(const String &content){
  server->send(200, FPSTR(HTTP_HEAD_CT), content);
}

As I have 14k page, I got empty answer, cause there is no additional 14k memory for copy =).

@dontsovcmc commented on GitHub (Mar 3, 2023): Maybe you have "refactoring" issue to write down easy changes? I found additional "small" enhancement: HTTPSend copies content variable ``` void WiFiManager::HTTPSend(String content){ server->send(200, FPSTR(HTTP_HEAD_CT), content); } ``` right way: ``` void WiFiManager::HTTPSend(const String &content){ server->send(200, FPSTR(HTTP_HEAD_CT), content); } ``` As I have 14k page, I got empty answer, cause there is no additional 14k memory for copy =).

kerem commented

2026-02-28 01:29:40 +03:00

Author

Owner

@tablatronix commented on GitHub (Mar 16, 2023):

Thanks catching that, i added that abstraction recently to help with another branch (async) and forgot about it

@tablatronix commented on GitHub (Mar 16, 2023): Thanks catching that, i added that abstraction recently to help with another branch (async) and forgot about it