[GH-ISSUE #1472] GitHub Actions don't appear to test as intended #1258

New issue

Closed

opened 2026-02-28 01:29:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:29:17 +03:00

Owner

Originally created by @thorrak on GitHub (Aug 9, 2022).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1472

Just a heads up - I don't think that your GitHub Actions are testing PRs as intended. From looking at the action, I noticed the following line:

https://github.com/tzapu/WiFiManager/blob/master/.github/workflows/compile_examples.yaml#L111

...which seems to re-clone the active master from your repo to build against rather than using the "incoming" code from a PR. To test this, I created this commit which deletes all the code, and then submitted this PR on which all the checks succeed.

My expectation is that compile examples should fail given all the code was deleted.

Originally created by @thorrak on GitHub (Aug 9, 2022). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1472 Just a heads up - I don't think that your GitHub Actions are testing PRs as intended. From looking at the action, I noticed the following line: https://github.com/tzapu/WiFiManager/blob/master/.github/workflows/compile_examples.yaml#L111 ...which seems to re-clone the active master from your repo to build against rather than using the "incoming" code from a PR. To test this, I created [this commit](https://github.com/tzapu/WiFiManager/pull/1471/commits/a4b5dc943bdcd1e99567b7ba1396543971343f14) which deletes all the code, and then submitted [this PR](https://github.com/tzapu/WiFiManager/pull/1471) on which all the checks succeed. My expectation is that compile examples should fail given all the code was deleted.