[GH-ISSUE #1348] WiFiManager should make defensive copy of hostname #1153

New issue

Closed

opened 2026-02-28 01:28:46 +03:00 by kerem · 2 comments

kerem commented

2026-02-28 01:28:46 +03:00

Owner

Originally created by @lptr on GitHub (Jan 26, 2022).
Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1348

Basic Infos

Hardware

WiFimanager Branch/Release: 2.0.5-beta
Hardware: ESP32

Description

WiFiManager::setHostname(char*) should make a defensive copy of parameter value instead of storing the raw parameter value. Currently it is possible to e.g. pass a hostname value that gets freed up before WiFi.setHostname() etc., resulting in a corrupted hostname being set.

Note: setCustomHeadElement(char*) probably suffers from the same problem.

Originally created by @lptr on GitHub (Jan 26, 2022). Original GitHub issue: https://github.com/tzapu/WiFiManager/issues/1348 ### Basic Infos #### Hardware WiFimanager Branch/Release: 2.0.5-beta Hardware: ESP32 ### Description `WiFiManager::setHostname(char*)` should make a defensive copy of parameter value instead of storing the raw parameter value. Currently it is possible to e.g. pass a `hostname` value that gets freed up before `WiFi.setHostname()` etc., resulting in a corrupted hostname being set. Note: `setCustomHeadElement(char*)` probably suffers from the same problem.

kerem

2026-02-28 01:28:46 +03:00

closed this issue
added the
bug

Good First Issue
labels

kerem commented

2026-02-28 01:28:46 +03:00

Author

Owner

@tablatronix commented on GitHub (Feb 2, 2022):

YES, I forgot all about this, but saw that a couple weeks ago.

Doesn't esp sethostname take something stange?

@tablatronix commented on GitHub (Feb 2, 2022): YES, I forgot all about this, but saw that a couple weeks ago. Doesn't esp sethostname take something stange?

kerem commented

2026-02-28 01:28:46 +03:00

Author

Owner

@tablatronix commented on GitHub (Feb 5, 2022):

No idea what works best here, ideas? I just changed it to string , it should copy and it seems to work now

@tablatronix commented on GitHub (Feb 5, 2022): No idea what works best here, ideas? I just changed it to string , it should copy and it seems to work now