[PR #218] [MERGED] Use DIRECTORY_SEPARATOR instead of DS #304

New issue

Closed

opened 2026-02-26 10:30:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 10:30:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/opensolutions/ViMbAdmin/pull/218
Author: @dereckson
Created: 12/28/2016
Status: ✅ Merged
Merged: 1/3/2017
Merged by: @barryo

Base: master ← Head: fix/DS

📝 Commits (1)

78b755c Use DIRECTORY_SEPARATOR instead of DS

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 library/ViMbAdmin/Smarty/functions/modifier.date_formatter.php (+2 -1)

📄 Description

The smarty_modifier_date_formatter function uses system path
to determine if the target OS is Windows.

PHP 4 introduced DIRECTORY_SEPARATOR, and DS isn't defined in
the current configuration and Smarty bootstrap process.

It so seems safe to switch to DIRECTORY_SEPARATOR.

Fixes #217.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/opensolutions/ViMbAdmin/pull/218 **Author:** [@dereckson](https://github.com/dereckson) **Created:** 12/28/2016 **Status:** ✅ Merged **Merged:** 1/3/2017 **Merged by:** [@barryo](https://github.com/barryo) **Base:** `master` ← **Head:** `fix/DS` --- ### 📝 Commits (1) - [`78b755c`](https://github.com/opensolutions/ViMbAdmin/commit/78b755c3cccd33ddce0aeb628611c365b8a36d3d) Use DIRECTORY_SEPARATOR instead of DS ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `library/ViMbAdmin/Smarty/functions/modifier.date_formatter.php` (+2 -1) </details> ### 📄 Description The smarty_modifier_date_formatter function uses system path to determine if the target OS is Windows. PHP 4 introduced DIRECTORY_SEPARATOR, and DS isn't defined in the current configuration and Smarty bootstrap process. It so seems safe to switch to DIRECTORY_SEPARATOR. Fixes #217. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>