[PR #201] [MERGED] Disallow non-super admins to add/edit domains #297

New issue

Closed

opened 2026-02-26 10:30:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 10:30:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/opensolutions/ViMbAdmin/pull/201
Author: @PhrozenByte
Created: 8/3/2016
Status: ✅ Merged
Merged: 8/3/2016
Merged by: @barryo

Base: master ← Head: patch-1

📝 Commits (2)

48bbea0 Disallow non-super admins to add/edit domains
a96b760 Remove domain edit button for non-super admins

📊 Changes

2 files changed (+7 additions, -3 deletions)

View changed files

📝 application/controllers/DomainController.php (+2 -0)
📝 application/views/domain/list.phtml (+5 -3)

📄 Description

Non-super admins simply don't have to visit the domain edit page. The only option non-super admins have write access to, is toggle-active. However, this option is already accessibly through the AJAX toggle button on the domain list page. The easiest solution is therefore to disallow navigating to the add (btw, non-super admins were able to create domains until now, however, they weren't able to assign admins to domains) and edit page.

Fixes #30, #181

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/opensolutions/ViMbAdmin/pull/201 **Author:** [@PhrozenByte](https://github.com/PhrozenByte) **Created:** 8/3/2016 **Status:** ✅ Merged **Merged:** 8/3/2016 **Merged by:** [@barryo](https://github.com/barryo) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`48bbea0`](https://github.com/opensolutions/ViMbAdmin/commit/48bbea06a8351b8f2da0f058bc336370885cb5bb) Disallow non-super admins to add/edit domains - [`a96b760`](https://github.com/opensolutions/ViMbAdmin/commit/a96b76031ef169eec9cefd67e994f938cde9b80e) Remove domain edit button for non-super admins ### 📊 Changes **2 files changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `application/controllers/DomainController.php` (+2 -0) 📝 `application/views/domain/list.phtml` (+5 -3) </details> ### 📄 Description Non-super admins simply don't have to visit the domain edit page. The only option non-super admins have write access to, is `toggle-active`. However, this option is already accessibly through the AJAX toggle button on the domain list page. The easiest solution is therefore to disallow navigating to the add (btw, non-super admins were able to create domains until now, however, they weren't able to assign admins to domains) and edit page. Fixes #30, #181 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>