[PR #123] [MERGED] updated max password length to 255 #284

Closed
opened 2026-02-26 10:30:37 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/opensolutions/ViMbAdmin/pull/123
Author: @vogan
Created: 1/5/2015
Status: Merged
Merged: 1/5/2015
Merged by: @barryo

Base: masterHead: opensolutions


📝 Commits (1)

  • 04768ad updated max password length to 255

📊 Changes

4 files changed (+6 additions, -6 deletions)

View changed files

📝 library/ViMbAdmin/Form/Admin/ChangePassword.php (+2 -2)
📝 library/ViMbAdmin/Form/Admin/Password.php (+1 -1)
📝 library/ViMbAdmin/Form/Mailbox/AddEdit.php (+1 -1)
📝 library/ViMbAdmin/Form/Mailbox/Password.php (+2 -2)

📄 Description

password limits are not necessary, due to the fact that the password will be hashed before storing. the length of 255 chars should be long enough for every user and it fits in the password field if any crazy admin wants to store them in plain text. if the application ensures that passwords can not be stored in plain text, the limit can be removed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/opensolutions/ViMbAdmin/pull/123 **Author:** [@vogan](https://github.com/vogan) **Created:** 1/5/2015 **Status:** ✅ Merged **Merged:** 1/5/2015 **Merged by:** [@barryo](https://github.com/barryo) **Base:** `master` ← **Head:** `opensolutions` --- ### 📝 Commits (1) - [`04768ad`](https://github.com/opensolutions/ViMbAdmin/commit/04768ad395c4ddc263b9a5096d20bfbb9106accd) updated max password length to 255 ### 📊 Changes **4 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `library/ViMbAdmin/Form/Admin/ChangePassword.php` (+2 -2) 📝 `library/ViMbAdmin/Form/Admin/Password.php` (+1 -1) 📝 `library/ViMbAdmin/Form/Mailbox/AddEdit.php` (+1 -1) 📝 `library/ViMbAdmin/Form/Mailbox/Password.php` (+2 -2) </details> ### 📄 Description password limits are not necessary, due to the fact that the password will be hashed before storing. the length of 255 chars should be long enough for every user and it fits in the password field if any crazy admin wants to store them in plain text. if the application ensures that passwords can not be stored in plain text, the limit can be removed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 10:30:37 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ViMbAdmin-opensolutions#284
No description provided.