[GH-ISSUE #268] alias editing : error #219

Closed
opened 2026-02-26 09:36:51 +03:00 by kerem · 2 comments
Owner

Originally created by @Rico29 on GitHub (Jun 18, 2020).
Original GitHub issue: https://github.com/opensolutions/ViMbAdmin/issues/268

Hello
I'm using master branch

I get an error when editing an email alias :
URL : https://vimbadmin.xxx.fr/alias/edit/alid/114
error : Parse error: syntax error, unexpected '?', expecting variable (T_VARIABLE) in /usr/share/vimbadmin/application/Proxies/__CG__EntitiesDomain.php on line 49

It seems that this syntax is not valid :

# sed -n 49p /usr/share/vimbadmin/application/Proxies/__CG__EntitiesDomain.php 
    public function __construct(?\Closure $initializer = null, ?\Closure $cloner = null)

removing the "?" seems OK, and I don't get the error anymore :

# sed -n 49p /usr/share/vimbadmin/application/Proxies/__CG__EntitiesDomain.php 
    public function __construct(\Closure $initializer = null, \Closure $cloner = null

Will propose a PR for that.

Originally created by @Rico29 on GitHub (Jun 18, 2020). Original GitHub issue: https://github.com/opensolutions/ViMbAdmin/issues/268 Hello I'm using master branch I get an error when editing an email alias : URL : https://vimbadmin.xxx.fr/alias/edit/alid/114 error : Parse error: syntax error, unexpected '?', expecting variable (T_VARIABLE) in /usr/share/vimbadmin/application/Proxies/__CG__EntitiesDomain.php on line 49 It seems that this syntax is not valid : ``` # sed -n 49p /usr/share/vimbadmin/application/Proxies/__CG__EntitiesDomain.php public function __construct(?\Closure $initializer = null, ?\Closure $cloner = null) ``` removing the "?" seems OK, and I don't get the error anymore : ``` # sed -n 49p /usr/share/vimbadmin/application/Proxies/__CG__EntitiesDomain.php public function __construct(\Closure $initializer = null, \Closure $cloner = null ``` Will propose a PR for that.
kerem closed this issue 2026-02-26 09:36:51 +03:00
Author
Owner

@Rico29 commented on GitHub (Jun 18, 2020):

This breaks vimbadmin in php5. works in php7

<!-- gh-comment-id:645896298 --> @Rico29 commented on GitHub (Jun 18, 2020): This breaks vimbadmin in php5. works in php7
Author
Owner

@barryo commented on GitHub (Apr 1, 2022):

Thanks @Rico29. I think in 2022 we don't need to worry about PHP5 anymore really.

<!-- gh-comment-id:1086288830 --> @barryo commented on GitHub (Apr 1, 2022): Thanks @Rico29. I think in 2022 we don't need to worry about PHP5 anymore really.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ViMbAdmin-opensolutions#219
No description provided.