mirror of
https://github.com/opensolutions/ViMbAdmin.git
synced 2026-04-26 16:55:59 +03:00
[GH-ISSUE #161] use of fopen #128
Labels
No labels
bug
feature
feature
improvement
improvement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ViMbAdmin-opensolutions#128
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @simongareste on GitHub (Dec 7, 2015).
Original GitHub issue: https://github.com/opensolutions/ViMbAdmin/issues/161
Hi,
You currently use fopen to check for new versions:
We recently had an attack through this very function last week, on another server, and had to switch off allow_url_fopen in php.ini
Would it be possible to check the latest version using another way?
@barryo commented on GitHub (Jan 7, 2016):
No, sorry 😢
There's nothing more or less insecure about
fopen()than any other function. It's just about how it's used.You're free to disable the version check altogether:
https://github.com/opensolutions/ViMbAdmin/blob/master/application/configs/application.ini.dist#L330
I do however appreciate that we could parse the response better. I'll commit a fix for that now - thanks for making me have a closer look 😄