[PR #58] [MERGED] fix: spec templates respect project type + iflow path drift + dead code cleanup #57

New issue

Closed

opened 2026-03-03 15:47:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:47:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mindfold-ai/Trellis/pull/58
Author: @taosu0216
Created: 3/2/2026
Status: ✅ Merged
Merged: 3/2/2026
Merged by: @taosu0216

Base: main ← Head: fix/spec-templates-and-iflow

📝 Commits (5)

8f15f36 fix: spec templates respect project type, remove cross-platform dead code
c22e904 chore: record session 57 — spec template bug fixes & dead code cleanup
817a2d2 fix: iflow collectTemplates missing trellis/ subdirectory in command paths
17cbfb8 docs(spec): update platform-integration + code-reuse guide for collectTemplates path drift
51ce56d docs(spec): add Antigravity platform documentation to platform-integration

📊 Changes

14 files changed (+368 additions, -124 deletions)

View changed files

📝 .trellis/spec/backend/platform-integration.md (+44 -4)
📝 .trellis/spec/guides/code-reuse-thinking-guide.md (+15 -0)
📝 .trellis/spec/unit-test/integration-patterns.md (+3 -1)
📝 .trellis/workspace/taosu/index.md (+3 -2)
📝 .trellis/workspace/taosu/journal-2.md (+42 -0)
📝 src/commands/update.ts (+54 -45)
📝 src/configurators/index.ts (+1 -1)
📝 src/configurators/workflow.ts (+62 -58)
📝 src/templates/markdown/index.ts (+0 -3)
📝 src/templates/markdown/spec/guides/code-reuse-thinking-guide.md.txt (+13 -0)
📝 src/templates/markdown/spec/guides/index.md.txt (+0 -10)
📝 test/commands/init.integration.test.ts (+29 -0)
📝 test/commands/update.integration.test.ts (+46 -0)
📝 test/regression.test.ts (+56 -0)

📄 Description

Summary

Spec template project type: createSpecTemplates() now respects projectType — backend-only projects skip frontend specs, frontend-only skip backend
Update template gating: collectTemplateFiles() checks fs.existsSync before including backend/frontend spec files
iFlow collectTemplates path: Fixed missing trellis/ subdirectory in iFlow command paths
Dead code cleanup: Removed unused guidesCrossPlatformThinkingGuideContent export and dead links in guides template
Spec docs: Updated platform-integration.md, code-reuse guide, added Antigravity platform docs

Test plan

pnpm lint passes
pnpm typecheck passes
pnpm test passes (377 tests)
New integration tests: backend/frontend project init skips correct spec dirs
New integration tests: update does not recreate removed spec dirs
New regression tests: all platforms with commands use trellis/ subdirectory

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mindfold-ai/Trellis/pull/58 **Author:** [@taosu0216](https://github.com/taosu0216) **Created:** 3/2/2026 **Status:** ✅ Merged **Merged:** 3/2/2026 **Merged by:** [@taosu0216](https://github.com/taosu0216) **Base:** `main` ← **Head:** `fix/spec-templates-and-iflow` --- ### 📝 Commits (5) - [`8f15f36`](https://github.com/mindfold-ai/Trellis/commit/8f15f36d1c7fd98310972672c0d9bab8d56d3348) fix: spec templates respect project type, remove cross-platform dead code - [`c22e904`](https://github.com/mindfold-ai/Trellis/commit/c22e904fdeae7a9827b850c9c0d133f253cd3f5b) chore: record session 57 — spec template bug fixes & dead code cleanup - [`817a2d2`](https://github.com/mindfold-ai/Trellis/commit/817a2d23fba4eb447b7d8d87e689485459bc9cd1) fix: iflow collectTemplates missing trellis/ subdirectory in command paths - [`17cbfb8`](https://github.com/mindfold-ai/Trellis/commit/17cbfb85950f4def0ef84adfd14ff0d39f02c8b2) docs(spec): update platform-integration + code-reuse guide for collectTemplates path drift - [`51ce56d`](https://github.com/mindfold-ai/Trellis/commit/51ce56daa0ea2d508534d0c71062602b43034168) docs(spec): add Antigravity platform documentation to platform-integration ### 📊 Changes **14 files changed** (+368 additions, -124 deletions) <details> <summary>View changed files</summary> 📝 `.trellis/spec/backend/platform-integration.md` (+44 -4) 📝 `.trellis/spec/guides/code-reuse-thinking-guide.md` (+15 -0) 📝 `.trellis/spec/unit-test/integration-patterns.md` (+3 -1) 📝 `.trellis/workspace/taosu/index.md` (+3 -2) 📝 `.trellis/workspace/taosu/journal-2.md` (+42 -0) 📝 `src/commands/update.ts` (+54 -45) 📝 `src/configurators/index.ts` (+1 -1) 📝 `src/configurators/workflow.ts` (+62 -58) 📝 `src/templates/markdown/index.ts` (+0 -3) 📝 `src/templates/markdown/spec/guides/code-reuse-thinking-guide.md.txt` (+13 -0) 📝 `src/templates/markdown/spec/guides/index.md.txt` (+0 -10) 📝 `test/commands/init.integration.test.ts` (+29 -0) 📝 `test/commands/update.integration.test.ts` (+46 -0) 📝 `test/regression.test.ts` (+56 -0) </details> ### 📄 Description ## Summary - **Spec template project type**: `createSpecTemplates()` now respects `projectType` — backend-only projects skip frontend specs, frontend-only skip backend - **Update template gating**: `collectTemplateFiles()` checks `fs.existsSync` before including backend/frontend spec files - **iFlow collectTemplates path**: Fixed missing `trellis/` subdirectory in iFlow command paths - **Dead code cleanup**: Removed unused `guidesCrossPlatformThinkingGuideContent` export and dead links in guides template - **Spec docs**: Updated platform-integration.md, code-reuse guide, added Antigravity platform docs ## Test plan - [x] `pnpm lint` passes - [x] `pnpm typecheck` passes - [x] `pnpm test` passes (377 tests) - [x] New integration tests: backend/frontend project init skips correct spec dirs - [x] New integration tests: update does not recreate removed spec dirs - [x] New regression tests: all platforms with commands use `trellis/` subdirectory --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>