[GH-ISSUE #114] about bc dependent #448

New issue

Closed

opened 2026-03-12 15:45:02 +03:00 by kerem · 8 comments

kerem commented 2026-03-12 15:45:02 +03:00

Owner

Copy link

Originally created by @wjz304 on GitHub (Sep 19, 2023).
Original GitHub issue: https://github.com/007revad/Synology_enable_M2_volume/issues/114

github.com/007revad/Synology_enable_M2_volume@96ecdb5225/syno_enable_m2_volume.sh (L157)
If not have, would be better to directly download it?
curl -kL https://raw.githubusercontent.com/007revad/Synology_enable_M2_volume/main/bin/bc -o /tmp/bc

Originally created by @wjz304 on GitHub (Sep 19, 2023). Original GitHub issue: https://github.com/007revad/Synology_enable_M2_volume/issues/114 https://github.com/007revad/Synology_enable_M2_volume/blob/96ecdb5225d2bfd9b9bec6284c796c138ed18920/syno_enable_m2_volume.sh#L157 If not have, would be better to directly download it? `curl -kL https://raw.githubusercontent.com/007revad/Synology_enable_M2_volume/main/bin/bc -o /tmp/bc`

kerem closed this issue 2026-03-12 15:45:07 +03:00

kerem commented 2026-03-12 15:45:13 +03:00

Author

Owner

Copy link

@wjz304 commented on GitHub (Sep 19, 2023):

github.com/007revad/Synology_enable_M2_volume@96ecdb5225/syno_enable_m2_volume.sh (L392)

Can we add a parameter to skip interaction?

<!-- gh-comment-id:1725119192 --> @wjz304 commented on GitHub (Sep 19, 2023): https://github.com/007revad/Synology_enable_M2_volume/blob/96ecdb5225d2bfd9b9bec6284c796c138ed18920/syno_enable_m2_volume.sh#L392 Can we add a parameter to skip interaction?

kerem commented 2026-03-12 15:45:18 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Sep 19, 2023):

If not have, would be better to directly download it?
curl -kL https://raw.githubusercontent.com/007revad/Synology_enable_M2_volume/main/bin/bc -o /tmp/bc

Yes. I added /bin/bc recently so I could have the script download it but hadn't got around to editing the script yet.

<!-- gh-comment-id:1725155979 --> @007revad commented on GitHub (Sep 19, 2023): > If not have, would be better to directly download it? > `curl -kL https://raw.githubusercontent.com/007revad/Synology_enable_M2_volume/main/bin/bc -o /tmp/bc` Yes. I added /bin/bc recently so I could have the script download it but hadn't got around to editing the script yet.

kerem commented 2026-03-12 15:45:23 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Sep 19, 2023):

Can we add a parameter to skip interaction?

Do you want to:

1. Skip interaction and have the script reboot the machine?
2. Or skip the rebootmsg function?

<!-- gh-comment-id:1725158162 --> @007revad commented on GitHub (Sep 19, 2023): > Can we add a parameter to skip interaction? Do you want to: 1. Skip interaction and have the script reboot the machine? 2. Or skip the rebootmsg function?

kerem commented 2026-03-12 15:45:28 +03:00

Author

Owner

Copy link

@wjz304 commented on GitHub (Sep 19, 2023):

Can we add a parameter to skip interaction?

Do you want to:

1. Skip interaction and have the script reboot the machine?
2. Or skip the rebootmsg function?

I want both

<!-- gh-comment-id:1725161340 --> @wjz304 commented on GitHub (Sep 19, 2023): > > Can we add a parameter to skip interaction? > > Do you want to: > > 1. Skip interaction and have the script reboot the machine? > 2. Or skip the rebootmsg function? I want both 

kerem commented 2026-03-12 15:45:33 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Sep 19, 2023):

Can we add a parameter to skip interaction?

Do you want to:

1. Skip interaction and have the script reboot the machine?
2. Or skip the rebootmsg function?

I want both

You want to skip interaction and reboot the machine while not rebooting the machine? :)

Or do you want 2 parameters so you have choice to either:

• Reboot without interaction.
• No interaction and no reboot.

<!-- gh-comment-id:1725195813 --> @007revad commented on GitHub (Sep 19, 2023): > > > Can we add a parameter to skip interaction? > > > > > > Do you want to: > > > > 1. Skip interaction and have the script reboot the machine? > > 2. Or skip the rebootmsg function? > > I want both You want to skip interaction and reboot the machine while not rebooting the machine? :) Or do you want 2 parameters so you have choice to either: - Reboot without interaction. - No interaction and no reboot.

kerem commented 2026-03-12 15:45:38 +03:00

Author

Owner

Copy link

@wjz304 commented on GitHub (Sep 19, 2023):

Can we add a parameter to skip interaction?

Do you want to:

1. Skip interaction and have the script reboot the machine?
2. Or skip the rebootmsg function?

I want both

You want to skip interaction and reboot the machine while not rebooting the machine? :)

Or do you want 2 parameters so you have choice to either:

• Reboot without interaction.
• No interaction and no reboot.

No interaction and no reboot.

The main issue is that there is no way to interact in addons (services), so skipping interaction is a priority.
As for restarting, from the user's subjective perspective, automatic restarting may not be good. So I think skipping the reboot should be good.

(Sorry, my English is very poor. I'm not sure if I can express myself clearly)

<!-- gh-comment-id:1725227193 --> @wjz304 commented on GitHub (Sep 19, 2023): > > > > Can we add a parameter to skip interaction? > > > > > > > > > Do you want to: > > > > > > 1. Skip interaction and have the script reboot the machine? > > > 2. Or skip the rebootmsg function? > > > > > > I want both > > You want to skip interaction and reboot the machine while not rebooting the machine? :) > > Or do you want 2 parameters so you have choice to either: > > * Reboot without interaction. > * No interaction and no reboot. `No interaction and no reboot.` The main issue is that there is no way to interact in addons (services), so skipping interaction is a priority. As for restarting, from the user's subjective perspective, automatic restarting may not be good. So I think skipping the reboot should be good. (Sorry, my English is very poor. I'm not sure if I can express myself clearly)

kerem commented 2026-03-12 15:45:44 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Sep 19, 2023):

Your English is good.

I've updated the script. https://github.com/007revad/Synology_enable_M2_volume/releases/tag/v1.0.10

• Added -n, --noreboot option to not reboot after script has run (and not show interactive).
• Changed to download and install bc, if needed.

<!-- gh-comment-id:1725346038 --> @007revad commented on GitHub (Sep 19, 2023): Your English is good. I've updated the script. https://github.com/007revad/Synology_enable_M2_volume/releases/tag/v1.0.10 - Added -n, --noreboot option to not reboot after script has run (and not show interactive). - Changed to download and install bc, if needed.

kerem commented 2026-03-12 15:45:49 +03:00

Author

Owner

Copy link

@wjz304 commented on GitHub (Sep 19, 2023):

Thx!,

<!-- gh-comment-id:1726037156 --> @wjz304 commented on GitHub (Sep 19, 2023): Thx!, 

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

develop

v1.1.22

v1.1.21

v1.1.20

v1.1.19

v1.1.18

v1.1.17

v1.1.15

V1.1.14

v1.1.13

v1.1.12-RC

v1.1.11-RC

v1.0.10

v1.0.9

v1.0.8

v1.0.7

v1.0.6

v1.0.5

v1.0.4

v1.0.3

v0.0.2

v0.0.1

Labels

Clear labels   

enhancement

  

pull-request

Mirrored from GitHub Pull Request

No labels

enhancement

pull-request

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/Synology_enable_M2_volume#448

No description provided.