mirror of
https://github.com/007revad/Synology_enable_M2_card.git
synced 2026-04-25 12:55:52 +03:00
[GH-ISSUE #34] FYI: Wrong EOL (End of Line) for Unix #3
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Synology_enable_M2_card#3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pitchea on GitHub (Jan 18, 2024).
Original GitHub issue: https://github.com/007revad/Synology_enable_M2_card/issues/34
Between version v3.0.9 and v3.0.11 the EOL changed from LF to CRLF. When I ran the 'syno_enable_m2_card.sh' (v3.0.11) script on my Syno DS1621+ I got the following error:
where the \r is a result of the CR from the Windows EOL encoding instead of the UNIX EOL encoding. Swapping it back to LF, the script works perfectly.
v3.0.11:
v3.0.9:
Similar thing happened with "Synology M2 volume" and "Synology HDD db" when I followed the post here
Thank you for the scripts :)
@007revad commented on GitHub (Jan 19, 2024):
How did you download the scripts?
Or did you view the script in Windows Notepad and click save?
@007revad commented on GitHub (Jan 19, 2024):
By the way, which M.2 card do you have?
I assume the syn_enable_m2_card script worked to enable the M.2 card and the syno_enable_hdd_db script allowed you to use storage manager to create a volume on the NVMe drive(s) in the M.2 card?
@pitchea commented on GitHub (Jan 19, 2024):
Ah, my apologies. After digging further, I realized it was my GitHub Desktop application when I cloned the repo and checked out the v3.0.11 tag. I never opened and viewed the file until I tried running it on my syno via ssh, but the git core.autocrlf was set to true on my Windows computer. Wiping out the file and git cloning it directly using git on Linux was fine.
I have the DS1621+ with an E10M20-T1 with two Samsung SSD 970 EVO Plus 2TB drives in the expansion card and another two in the built-in M.2 slots. They all work, thanks to your scripts. It appears the NIC also works. Cheers