mirror of
https://github.com/007revad/Synology_enable_Deduplication.git
synced 2026-04-25 12:46:03 +03:00
[GH-ISSUE #46] M.2 warning displays escape code instead of using yellow color #187
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Synology_enable_Deduplication#187
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @herbingk on GitHub (Jan 5, 2024).
Original GitHub issue: https://github.com/007revad/Synology_enable_Deduplication/issues/46
M.2 warning displays escape code instead of using yellow color. Occurs with the Synology_HDD_db script as well.
Seems like the -e param is missing from the echo statement:
echo "${Yellow}WARNING${Off} Don't store this script on an NVMe volume!"
Sample output:
Synology_enable_Deduplication v1.2.15
DS1621+ DSM 7.2.1-69057-3
StorageManager 1.0.0-0017
Using options: -c
Running from: /volume1/admin/Synology_Enable_Dedupe/syno_enable_dedupe.sh
\e[0;33mWARNING\e[0m Don't store this script on an NVMe volume!
Thanks for loooking into it.
@007revad commented on GitHub (Jan 5, 2024):
Thanks.
I just checked and 5 of my scripts are missing the -e for that warning!
@007revad commented on GitHub (Jan 7, 2024):
Fixed in https://github.com/007revad/Synology_enable_Deduplication/releases/tag/v1.2.17
Thank you.