starred/Synology_M2_volume
1
0
Fork 0
mirror of https://github.com/007revad/Synology_M2_volume.git synced 2026-04-25 07:46:05 +03:00
Code Issues 12 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #61] Kudos! #211

New issue
Closed
opened 2026-03-12 18:08:11 +03:00 by kerem · 2 comments
kerem commented 2026-03-12 18:08:11 +03:00
Owner
Copy link

Originally created by @mceachen on GitHub (Jun 14, 2023).
Original GitHub issue: https://github.com/007revad/Synology_M2_volume/issues/61

Thanks for this work!

In case you've not seen it before, shellcheck is a great linter for shell, and integrates with a bunch of editors (I use the this extension with vscode, fwiw).

It didn't find anything horrible here--just a few nits:

 shellcheck syno_create_m2_volume.sh 

In syno_create_m2_volume.sh line 79:
[ "$BASH" ] && ! shopt -qo posix || {
            ^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true.


In syno_create_m2_volume.sh line 127:
    minor=$(get_key_value /etc.defaults/VERSION minor)
    ^---^ SC2034 (warning): minor appears unused. Verify use (or export if used externally).


In syno_create_m2_volume.sh line 151:
args="$@"
     ^--^ SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.


In syno_create_m2_volume.sh line 176:
                log=yes
                ^-^ SC2034 (warning): log appears unused. Verify use (or export if used externally).


In syno_create_m2_volume.sh line 179:
                debug=yes
                ^---^ SC2034 (warning): debug appears unused. Verify use (or export if used externally).


In syno_create_m2_volume.sh line 216:
    dsm72="yes"
    ^---^ SC2034 (warning): dsm72 appears unused. Verify use (or export if used externally).


In syno_create_m2_volume.sh line 348:
                                delerr=1
                                ^----^ SC2034 (warning): delerr appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- debug appears unused. Verify use ...
  https://www.shellcheck.net/wiki/SC2124 -- Assigning an array to a string! A...
  https://www.shellcheck.net/wiki/SC2015 -- Note that A && B || C is not if-t...

Feel free to close this issue--I just wanted to stop by and thank you for your work.

(I found this project via https://www.mklibrary.com/synology-nvme-volume/)

Cheers!

Originally created by @mceachen on GitHub (Jun 14, 2023). Original GitHub issue: https://github.com/007revad/Synology_M2_volume/issues/61 Thanks for this work! In case you've not seen it before, [shellcheck](https://github.com/koalaman/shellcheck) is a great linter for shell, and integrates with a bunch of editors (I use the [this extension](https://marketplace.visualstudio.com/items?itemName=timonwong.shellcheck) with vscode, fwiw). It didn't find anything horrible here--just a few nits: ``` shellcheck syno_create_m2_volume.sh In syno_create_m2_volume.sh line 79: [ "$BASH" ] && ! shopt -qo posix || { ^-- SC2015 (info): Note that A && B || C is not if-then-else. C may run when A is true. In syno_create_m2_volume.sh line 127: minor=$(get_key_value /etc.defaults/VERSION minor) ^---^ SC2034 (warning): minor appears unused. Verify use (or export if used externally). In syno_create_m2_volume.sh line 151: args="$@" ^--^ SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. In syno_create_m2_volume.sh line 176: log=yes ^-^ SC2034 (warning): log appears unused. Verify use (or export if used externally). In syno_create_m2_volume.sh line 179: debug=yes ^---^ SC2034 (warning): debug appears unused. Verify use (or export if used externally). In syno_create_m2_volume.sh line 216: dsm72="yes" ^---^ SC2034 (warning): dsm72 appears unused. Verify use (or export if used externally). In syno_create_m2_volume.sh line 348: delerr=1 ^----^ SC2034 (warning): delerr appears unused. Verify use (or export if used externally). For more information: https://www.shellcheck.net/wiki/SC2034 -- debug appears unused. Verify use ... https://www.shellcheck.net/wiki/SC2124 -- Assigning an array to a string! A... https://www.shellcheck.net/wiki/SC2015 -- Note that A && B || C is not if-t... ``` Feel free to close this issue--I just wanted to stop by and thank you for your work. (I found this project via https://www.mklibrary.com/synology-nvme-volume/) Cheers!
kerem closed this issue 2026-03-12 18:08:17 +03:00
kerem commented 2026-03-12 18:08:23 +03:00
Author
Owner
Copy link

@007revad commented on GitHub (Jun 16, 2023):

(I found this project via https://www.mklibrary.com/synology-nvme-volume/)

That's a well written guide. I might put a link to it on my readme page.

I do use shellcheck.

  • The args="$@" is just so I can echo the arguments used. But I could change it args=("$@")
  • The unused variables are for future use.
  • Line 79 is something that does work when the script is in a different shell 9to check it's running in bash) even though shellcheck warns that it's not an "if, then, else".
<!-- gh-comment-id:1594053084 --> @007revad commented on GitHub (Jun 16, 2023): > (I found this project via https://www.mklibrary.com/synology-nvme-volume/) That's a well written guide. I might put a link to it on my readme page. I do use shellcheck. - The `args="$@"` is just so I can echo the arguments used. But I could change it `args=("$@")` - The unused variables are for future use. - Line 79 is something that does work when the script is in a different shell 9to check it's running in bash) even though shellcheck warns that it's not an "if, then, else".
kerem commented 2026-03-12 18:08:28 +03:00
Author
Owner
Copy link

@mceachen commented on GitHub (Jun 16, 2023):

ICYMI, you can prepend the line # shellcheck disable=SC2015 (or whatever the warning is) right above the offending line of code if you've checked out the linting error and have determined it's a false positive or otherwise ignorable. Docs are here.

Thanks again.

<!-- gh-comment-id:1594968861 --> @mceachen commented on GitHub (Jun 16, 2023): ICYMI, you can prepend the line `# shellcheck disable=SC2015` (or whatever the warning is) right above the offending line of code if you've checked out the linting error and have determined it's a false positive or otherwise ignorable. [Docs are here.](https://www.shellcheck.net/wiki/Ignore) Thanks again.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
develop
v1
test
v1.3.26
v2.1.31
v2.0.30
v2.0.29
v2.0.28
v2.0.27
v10.0.0-TEST2
v10.0.0-TEST
v2.0.26
v1.3.25
v1.3.24
v1.3.23
v1.3.22
v1.3.21
v1.3.20
v1.3.19
v1.3.18
v1.3.17
v1.3.16
v1.3.15
v1.2.14
v1.2.13
v1.3.12
v1.2.12
v1.2.11
v1.2.10
v1.2.9
v1.1.8
v1.1.7
v1.1.6
v1.1.5
v1.1.4
v1.0.3
v1.0.2
v1.0.2-beta
v1.0.1-beta
Labels
Clear labels   
bug

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Synology_M2_volume#211
No description provided.