mirror of
https://github.com/007revad/Synology_HDD_db.git
synced 2026-04-25 21:55:59 +03:00
[GH-ISSUE #200] Small glitch in the code ? #582
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Synology_HDD_db#582
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kia0ra on GitHub (Jan 7, 2024).
Original GitHub issue: https://github.com/007revad/Synology_HDD_db/issues/200
Hi,
Thanks a lot for your scripts, they are awesome !
I have just noticed a small parse error while running it, I am sharing it with you.
`root@nas:/volume1/script# ./syno_hdd_db.sh -nr --showedits
Synology_HDD_db v3.3.75
DS220+ DSM 7.2.1-69057-3
StorageManager 1.0.0-0017
Using options: -nr --showedits
Running from: /volume1/script/syno_hdd_db.sh
HDD/SSD models found: 1
WD160EDGZ-11B2DA0,85.00A85
No M.2 drives found
No M.2 PCIe cards found
No Expansion Units found
WD160EDGZ-11B2DA0 already exists in ds220+_host_v7.db
Support disk compatibility already enabled.
Support memory compatibility already disabled.
Max memory already set to 18 GB.
Drive db auto updates already disabled.
parse error: Expected value before ',' at line 1, column 96319
DSM successfully checked disk compatibility.
You may need to reboot the Synology to see the changes.
`
@007revad commented on GitHub (Jan 7, 2024):
I suspect if you run it again with --showedits it will show the same error.
And if you run it without --showedits it won't show the error.
Does the following command give the same error?
If it does give the same error can you attach a zipped copy of your ds220+_host_v7.db file.
You can copy the file to the script shared folder with:
@timekone commented on GitHub (Jan 7, 2024):
I've encountered a similar error. It only happens when running with --showedits.
@Kia0ra commented on GitHub (Jan 7, 2024):
Yes
Exact
root@nas:/volume1/scripts# jq . ds220+_host_v7.db | grep -A 11 WD160EDGZ-11B2DA0 parse error: Expected value before ',' at line 1, column 96319Exact same error
You can find the .db file in attachment
Thanks !
ds220+_host_v7.db.zip
@007revad commented on GitHub (Jan 7, 2024):
Ok, I've found the issue. My script has added an extra comma so the file ends in
,,"nas_model":"ds220+"}when it should end in,"nas_model":"ds220+"}I'll update the script to prevent that, and fix it in the db file for people who've already run Synology_HDD_db v3.3.75
@007revad commented on GitHub (Jan 7, 2024):
This new version v3.4.76 should work correctly with the -s or --showedits option. It also edits the ,db files to fix the ,, left from v3.3.75
https://github.com/007revad/Synology_HDD_db/releases/tag/v3.4.76
@Kia0ra commented on GitHub (Jan 8, 2024):
I think there's still a problem with the sed command :
@007revad commented on GitHub (Jan 8, 2024):
I guess it helps if I tell sed which files to edit :(
All fixed now: https://github.com/007revad/Synology_HDD_db/releases/tag/v3.4.77
@Kia0ra commented on GitHub (Jan 8, 2024):
It definitely helps ;)
Thanks for the support and reactiveness !