[GH-ISSUE #559] The code for removing spaces in the hdmodel variable within the getdriveinfo() function is unreasonable. #204

New issue

Closed

opened 2026-03-07 19:16:59 +03:00 by kerem · 22 comments

kerem commented 2026-03-07 19:16:59 +03:00

Owner

Copy link

Originally created by @MeowPerth on GitHub (Feb 10, 2026).
Original GitHub issue: https://github.com/007revad/Synology_HDD_db/issues/559

getdriveinfo(){ 
    # $1 is /sys/block/sata1 etc

    # Skip USB drives
    usb=$(grep "$(basename -- "$1")" /proc/mounts | grep "[Uu][Ss][Bb]" | cut -d" " -f1-2)
    if [[ ! $usb ]]; then

        # Get drive model
        hdmodel=$(cat "$1/device/model")
        #hdmodel=$(printf "%s" "$hdmodel" | xargs)  # trim leading and trailing white space
        hdmodel=$(echo "$hdmodel" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')

Using "xargs" will cause spaces between characters in the "hdmodel" parameter to be removed.
Example:

hdmodel=“0                      @”
hdmodel=$(printf "%s" "$hdmodel" | xargs)
echo "$hdmodel"
# output: [0 @]

If only removing leading and trailing spaces, it is recommended to use:

hdmodel=$(echo` "$hdmodel" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')

Originally created by @MeowPerth on GitHub (Feb 10, 2026). Original GitHub issue: https://github.com/007revad/Synology_HDD_db/issues/559 getdriveinfo(){ # $1 is /sys/block/sata1 etc # Skip USB drives usb=$(grep "$(basename -- "$1")" /proc/mounts | grep "[Uu][Ss][Bb]" | cut -d" " -f1-2) if [[ ! $usb ]]; then # Get drive model hdmodel=$(cat "$1/device/model") #hdmodel=$(printf "%s" "$hdmodel" | xargs) # trim leading and trailing white space hdmodel=$(echo "$hdmodel" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//') Using "xargs" will cause spaces between characters in the "hdmodel" parameter to be removed. Example: hdmodel=“0 @” hdmodel=$(printf "%s" "$hdmodel" | xargs) echo "$hdmodel" # output: [0 @] If only removing leading and trailing spaces, it is recommended to use: hdmodel=$(echo` "$hdmodel" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')

kerem closed this issue 2026-03-07 19:17:00 +03:00

kerem commented 2026-03-07 19:17:00 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Feb 10, 2026):

You make a valid point... but have you ever seen a HDD, SSD or NVMe with multiple spaces between strings in it's model name or firmware version?

<!-- gh-comment-id:3880374383 --> @007revad commented on GitHub (Feb 10, 2026): You make a valid point... but have you ever seen a HDD, SSD or NVMe with multiple spaces between strings in it's model name or firmware version?

kerem commented 2026-03-07 19:17:00 +03:00

Author

Owner

Copy link

@MeowPerth commented on GitHub (Feb 11, 2026):

You make a valid point... but have you ever seen a HDD, SSD or NVMe with multiple spaces between strings in it's model name or firmware version?

This situation is indeed quite rare; I have only seen it on hard drives that have had their firmware reflashed by third parties.

<!-- gh-comment-id:3881600040 --> @MeowPerth commented on GitHub (Feb 11, 2026): > You make a valid point... but have you ever seen a HDD, SSD or NVMe with multiple spaces between strings in it's model name or firmware version? This situation is indeed quite rare; I have only seen it on hard drives that have had their firmware reflashed by third parties. <img width="1213" height="787" alt="Image" src="https://github.com/user-attachments/assets/141edb8c-2a44-4d20-a82f-31b7b60af824" />

kerem commented 2026-03-07 19:17:00 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Feb 12, 2026):

Fixed in https://github.com/007revad/Synology_HDD_db/releases/tag/v3.6.120

<!-- gh-comment-id:3887939624 --> @007revad commented on GitHub (Feb 12, 2026): Fixed in https://github.com/007revad/Synology_HDD_db/releases/tag/v3.6.120

kerem commented 2026-03-07 19:17:00 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Feb 12, 2026):

That does not work. It does not trim leading and trailing spaces.

root@DISKSTATION:~# hdmodel=$(cat "/sys/block/sata3/device/model")
root@DISKSTATION:~# echo \'"$hdmodel"\'
'ST16000VN001-2YU101     '

root@DISKSTATION:~# hdmodel2="$(echo "$hdmodel" | sed 's/^[[:space:]]//;s/[[:space:]]$//')"
root@DISKSTATION:~# echo \'"$hdmodel2"\'
'ST16000VN001-2YU101    '

But bash parameter expansion does.

root@DISKSTATION:~# hdmodel3="${hdmodel%"${hdmodel##*[![:space:]]}"}"
root@DISKSTATION:~# echo \'"$hdmodel3"\'
'ST16000VN001-2YU101'

root@DISKSTATION:~# hdmodel="ST1600  VN001 - 2YU101    "
root@DISKSTATION:~# hdmodel3="${hdmodel%"${hdmodel##*[![:space:]]}"}"
root@DISKSTATION:~# echo \'"$hdmodel3"\'
'ST1600  VN001 - 2YU101'
```

<!-- gh-comment-id:3888658443 --> @007revad commented on GitHub (Feb 12, 2026): That does not work. It does not trim leading and trailing spaces. ``` root@DISKSTATION:~# hdmodel=$(cat "/sys/block/sata3/device/model") root@DISKSTATION:~# echo \'"$hdmodel"\' 'ST16000VN001-2YU101 ' root@DISKSTATION:~# hdmodel2="$(echo "$hdmodel" | sed 's/^[[:space:]]//;s/[[:space:]]$//')" root@DISKSTATION:~# echo \'"$hdmodel2"\' 'ST16000VN001-2YU101 ' ``` But bash parameter expansion does. ```` root@DISKSTATION:~# hdmodel3="${hdmodel%"${hdmodel##*[![:space:]]}"}" root@DISKSTATION:~# echo \'"$hdmodel3"\' 'ST16000VN001-2YU101' root@DISKSTATION:~# hdmodel="ST1600 VN001 - 2YU101 " root@DISKSTATION:~# hdmodel3="${hdmodel%"${hdmodel##*[![:space:]]}"}" root@DISKSTATION:~# echo \'"$hdmodel3"\' 'ST1600 VN001 - 2YU101' ```

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@MeowPerth commented on GitHub (Feb 12, 2026):

Sorry, that was my oversight. I missed entering "*" here in the issue; additionally, I have attached my local verification results.

<!-- gh-comment-id:3888763901 --> @MeowPerth commented on GitHub (Feb 12, 2026): Sorry, that was my oversight. I missed entering "*" here in the issue; additionally, I have attached my local verification results. <img width="980" height="367" alt="Image" src="https://github.com/user-attachments/assets/dec23f7a-ed04-4c73-b64a-9b5464caccf5" /> <img width="854" height="336" alt="Image" src="https://github.com/user-attachments/assets/8a13b74b-cfe5-4607-9747-54afb5a46f4b" /> <img width="929" height="118" alt="Image" src="https://github.com/user-attachments/assets/4a22e340-6540-4e83-9415-6e799193f31b" />

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@MeowPerth commented on GitHub (Feb 12, 2026):

Found the cause, using Quote '>' display will cause "*" not to be displayed.😂😂😂

<!-- gh-comment-id:3888797088 --> @MeowPerth commented on GitHub (Feb 12, 2026): Found the cause, using Quote '>' display will cause "*" not to be displayed.😂😂😂 <img width="1086" height="747" alt="Image" src="https://github.com/user-attachments/assets/26db5c8e-c2a6-4efd-ac19-77b596b0ea8a" />

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@MeowPerth commented on GitHub (Feb 12, 2026):

Corrected the issue description.

<!-- gh-comment-id:3888832475 --> @MeowPerth commented on GitHub (Feb 12, 2026): Corrected the issue description.

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Feb 12, 2026):

Can you try this version before I create a public release.
https://github.com/007revad/Synology_HDD_db/blob/develop/syno_hdd_db.sh

<!-- gh-comment-id:3893710428 --> @007revad commented on GitHub (Feb 12, 2026): Can you try this version before I create a public release. https://github.com/007revad/Synology_HDD_db/blob/develop/syno_hdd_db.sh

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@benhwebster commented on GitHub (Feb 13, 2026):

Can you try this version before I create a public release. https://github.com/007revad/Synology_HDD_db/blob/develop/syno_hdd_db.sh

I can verify this works for me.

$ sudo -s /opt/syno_hdd_db.sh
Synology_HDD_db v3.6.122
RS2825rp+ x86_64 DSM 7.3.2-86009-1
- StorageManager 1.0.1-1100
- SynoOnlinePack_v2 version 1038
- rs2825rp+_host_v7 version 8009

Running from: /opt/syno_hdd_db.sh
Running in interactive shell

HDD/SSD models found: 1
ST28000NM000C-3WM103,SN04,28001 GB

No M.2 drives found

No M.2 PCIe cards found

No Expansion Units found

Added ST28000NM000C-3WM103 (SN04) to rs2825rp+_host_v7.db
Edited unverified drives in rs2825rp+_host_v7.db

Support disk compatibility already enabled.

Drive db auto updates already enabled.

DSM successfully checked disk compatibility.

You may need to reboot the Synology to see the changes.

<!-- gh-comment-id:3894725270 --> @benhwebster commented on GitHub (Feb 13, 2026): > Can you try this version before I create a public release. https://github.com/007revad/Synology_HDD_db/blob/develop/syno_hdd_db.sh I can verify this works for me. ``` $ sudo -s /opt/syno_hdd_db.sh Synology_HDD_db v3.6.122 RS2825rp+ x86_64 DSM 7.3.2-86009-1 - StorageManager 1.0.1-1100 - SynoOnlinePack_v2 version 1038 - rs2825rp+_host_v7 version 8009 Running from: /opt/syno_hdd_db.sh Running in interactive shell HDD/SSD models found: 1 ST28000NM000C-3WM103,SN04,28001 GB No M.2 drives found No M.2 PCIe cards found No Expansion Units found Added ST28000NM000C-3WM103 (SN04) to rs2825rp+_host_v7.db Edited unverified drives in rs2825rp+_host_v7.db Support disk compatibility already enabled. Drive db auto updates already enabled. DSM successfully checked disk compatibility. You may need to reboot the Synology to see the changes. ```

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@MeowPerth commented on GitHub (Feb 13, 2026):

Can you try this version before I create a public release. https://github.com/007revad/Synology_HDD_db/blob/develop/syno_hdd_db.sh

This script runs fine on my NAS. But, it seems that with this version, any option directly runs the script, while version 3.6.119 does not have this issue.

<!-- gh-comment-id:3896216613 --> @MeowPerth commented on GitHub (Feb 13, 2026): > Can you try this version before I create a public release. https://github.com/007revad/Synology_HDD_db/blob/develop/syno_hdd_db.sh This script runs fine on my NAS. But, it seems that with this version, any option directly runs the script, while version 3.6.119 does not have this issue. <img width="1288" height="1139" alt="Image" src="https://github.com/user-attachments/assets/b189c47c-857a-4b9b-9b0d-731e9feca7ec" />

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Feb 13, 2026):

I've fixed the getopts issue. Can you try this one:
https://github.com/007revad/Synology_HDD_db/blob/develop/syno_hdd_db.sh

<!-- gh-comment-id:3898071181 --> @007revad commented on GitHub (Feb 13, 2026): I've fixed the getopts issue. Can you try this one: https://github.com/007revad/Synology_HDD_db/blob/develop/syno_hdd_db.sh

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@MeowPerth commented on GitHub (Feb 14, 2026):

I've fixed the getopts issue. Can you try this one: https://github.com/007revad/Synology_HDD_db/blob/develop/syno_hdd_db.sh

Line 120 should be deleted, and then it will run normally.

If using \, it should only be placed at the end of a parameter and should not break a complete parameter.

<!-- gh-comment-id:3901062391 --> @MeowPerth commented on GitHub (Feb 14, 2026): > I've fixed the getopts issue. Can you try this one: https://github.com/007revad/Synology_HDD_db/blob/develop/syno_hdd_db.sh Line 120 should be deleted, and then it will run normally. <img width="1154" height="191" alt="Image" src="https://github.com/user-attachments/assets/9ac11474-026c-4773-83ca-03b01e073697" /> If using `\`, it should only be placed at the end of a parameter and should not break a complete parameter. <img width="1170" height="122" alt="Image" src="https://github.com/user-attachments/assets/8e0e4a02-6a79-4f30-b8ea-a97e573d2182" />

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Feb 14, 2026):

Fixed and released.
https://github.com/007revad/Synology_HDD_db/releases/tag/v3.6.122

<!-- gh-comment-id:3901310760 --> @007revad commented on GitHub (Feb 14, 2026): Fixed and released. https://github.com/007revad/Synology_HDD_db/releases/tag/v3.6.122

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@francoism90 commented on GitHub (Feb 14, 2026):

@007revad Thanks for the fix! This seems to fix my missing drive as well:

HDD/SSD models found: 3
WD80EDAZ-11TA3A0,81.00A81,8001 GB
WD80EDBZ-11B0ZA0,85.00A85,8001 GB
 WUH721816ALE6L4,PCGNW680,16000 GB

WD80EDAZ-11TA3A0 (81.00A81) already exists in ds923+_host_v7.db
WD80EDAZ-11TA3A0 (81.00A81) already exists in ds923+_host_v7.db.new
WD80EDBZ-11B0ZA0 (85.00A85) already exists in ds923+_host_v7.db
WD80EDBZ-11B0ZA0 (85.00A85) already exists in ds923+_host_v7.db.new
Added  WUH721816ALE6L4 (PCGNW680) to ds923+_host_v7.db
Added  WUH721816ALE6L4 (PCGNW680) to ds923+_host_v7.db.new

I don't know where .db.new comes from, but I didn't noticed before it indeed has a space before the drive name.

<!-- gh-comment-id:3901663858 --> @francoism90 commented on GitHub (Feb 14, 2026): @007revad Thanks for the fix! This seems to fix my missing drive as well: ```bash HDD/SSD models found: 3 WD80EDAZ-11TA3A0,81.00A81,8001 GB WD80EDBZ-11B0ZA0,85.00A85,8001 GB WUH721816ALE6L4,PCGNW680,16000 GB WD80EDAZ-11TA3A0 (81.00A81) already exists in ds923+_host_v7.db WD80EDAZ-11TA3A0 (81.00A81) already exists in ds923+_host_v7.db.new WD80EDBZ-11B0ZA0 (85.00A85) already exists in ds923+_host_v7.db WD80EDBZ-11B0ZA0 (85.00A85) already exists in ds923+_host_v7.db.new Added WUH721816ALE6L4 (PCGNW680) to ds923+_host_v7.db Added WUH721816ALE6L4 (PCGNW680) to ds923+_host_v7.db.new ``` I don't know where .db.new comes from, but I didn't noticed before it indeed has a space before the drive name.

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@MeowPerth commented on GitHub (Feb 14, 2026):

Fixed and released. https://github.com/007revad/Synology_HDD_db/releases/tag/v3.6.122

Ok，Thanks.

<!-- gh-comment-id:3901695810 --> @MeowPerth commented on GitHub (Feb 14, 2026): > Fixed and released. https://github.com/007revad/Synology_HDD_db/releases/tag/v3.6.122 Ok，Thanks.

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Feb 14, 2026):

@francoism90
DSM creates the .db.new files when it updates the drive databases.

The Ultrastar HDD should not have space before WUH721816ALE6L4

What does these commands return?

 jq . /var/lib/disk-compatibility/ds923+_host_v7.db | grep 'WUH721816ALE6L4'
 jq . /var/lib/disk-compatibility/ds923+_host_v7.db | tail -50

<!-- gh-comment-id:3901803365 --> @007revad commented on GitHub (Feb 14, 2026): @francoism90 DSM creates the .db.new files when it updates the drive databases. The Ultrastar HDD should not have space before WUH721816ALE6L4 What does these commands return? ``` jq . /var/lib/disk-compatibility/ds923+_host_v7.db | grep 'WUH721816ALE6L4' jq . /var/lib/disk-compatibility/ds923+_host_v7.db | tail -50 ```

kerem commented 2026-03-07 19:17:01 +03:00

Author

Owner

Copy link

@francoism90 commented on GitHub (Feb 14, 2026):

@007revad

jq . /var/lib/disk-compatibility/ds923+_host_v7.db | grep 'WUH721816ALE6L4'
    "WUH721816ALE6L4": {
    " WUH721816ALE6L4": {

jq . /var/lib/disk-compatibility/ds923+_host_v7.db | tail -50
          }
        ]
      },
      "default": {
        "size_gb": 250,
        "compatibility_interval": [
          {
            "compatibility": "support",
            "not_yet_rolling_status": "support",
            "fw_dsm_update_status_notify": false,
            "barebone_installable": true,
            "barebone_installable_v2": "auto",
            "smart_test_ignore": false,
            "smart_attr_ignore": false
          }
        ]
      }
    },
    " WUH721816ALE6L4": {
      "PCGNW680": {
        "compatibility_interval": [
          {
            "compatibility": "support",
            "not_yet_rolling_status": "support",
            "fw_dsm_update_status_notify": false,
            "barebone_installable": true,
            "barebone_installable_v2": "auto",
            "smart_test_ignore": false,
            "smart_attr_ignore": false
          }
        ]
      },
      "default": {
        "size_gb": 16000,
        "compatibility_interval": [
          {
            "compatibility": "support",
            "not_yet_rolling_status": "support",
            "fw_dsm_update_status_notify": false,
            "barebone_installable": true,
            "barebone_installable_v2": "auto",
            "smart_test_ignore": false,
            "smart_attr_ignore": false
          }
        ]
      }
    }
  },
  "nas_model": "ds923+"
}

Thanks for looking into this. Maybe it's a Synology bug?

<!-- gh-comment-id:3902360489 --> @francoism90 commented on GitHub (Feb 14, 2026): @007revad ``` jq . /var/lib/disk-compatibility/ds923+_host_v7.db | grep 'WUH721816ALE6L4' "WUH721816ALE6L4": { " WUH721816ALE6L4": { ``` ``` jq . /var/lib/disk-compatibility/ds923+_host_v7.db | tail -50 } ] }, "default": { "size_gb": 250, "compatibility_interval": [ { "compatibility": "support", "not_yet_rolling_status": "support", "fw_dsm_update_status_notify": false, "barebone_installable": true, "barebone_installable_v2": "auto", "smart_test_ignore": false, "smart_attr_ignore": false } ] } }, " WUH721816ALE6L4": { "PCGNW680": { "compatibility_interval": [ { "compatibility": "support", "not_yet_rolling_status": "support", "fw_dsm_update_status_notify": false, "barebone_installable": true, "barebone_installable_v2": "auto", "smart_test_ignore": false, "smart_attr_ignore": false } ] }, "default": { "size_gb": 16000, "compatibility_interval": [ { "compatibility": "support", "not_yet_rolling_status": "support", "fw_dsm_update_status_notify": false, "barebone_installable": true, "barebone_installable_v2": "auto", "smart_test_ignore": false, "smart_attr_ignore": false } ] } } }, "nas_model": "ds923+" } ``` Thanks for looking into this. Maybe it's a Synology bug?

kerem commented 2026-03-07 19:17:02 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Feb 16, 2026):

With a leading space this looks wrong " WUH721816ALE6L4": {

But because jq found 2 entries DSM should be using the first entry, which does not have the leading space.

jq . /var/lib/disk-compatibility/ds923+_host_v7.db | grep 'WUH721816ALE6L4'
    "WUH721816ALE6L4": {
    " WUH721816ALE6L4": {

DSM does append 5 spaces to the end of drive models (which they have done to try and break this script. But I've never seen a space at the beginning of a drive model before.

What do these commands return?

m="$(cat /sys/block/sata1/device/model)"; echo "'$m'"
m="$(cat /sys/block/sata2/device/model)"; echo "'$m'"
m="$(cat /sys/block/sata3/device/model)"; echo "'$m'"
m="$(cat /sys/block/sata4/device/model)"; echo "'$m'"

<!-- gh-comment-id:3906933031 --> @007revad commented on GitHub (Feb 16, 2026): With a leading space this looks wrong `" WUH721816ALE6L4": {` But because jq found 2 entries DSM should be using the first entry, which does not have the leading space. ``` jq . /var/lib/disk-compatibility/ds923+_host_v7.db | grep 'WUH721816ALE6L4' "WUH721816ALE6L4": { " WUH721816ALE6L4": { ``` DSM does append 5 spaces to the end of drive models (which they have done to try and break this script. But I've never seen a space at the beginning of a drive model before. What do these commands return? ``` m="$(cat /sys/block/sata1/device/model)"; echo "'$m'" m="$(cat /sys/block/sata2/device/model)"; echo "'$m'" m="$(cat /sys/block/sata3/device/model)"; echo "'$m'" m="$(cat /sys/block/sata4/device/model)"; echo "'$m'" ```

kerem commented 2026-03-07 19:17:02 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Feb 16, 2026):

Thanks for the fix! This seems to fix my missing drive as well:

Are you saying the script never found the WUH721816ALE6L4 drive(s) before or it did but the drive still showed as unverfied?

<!-- gh-comment-id:3906940764 --> @007revad commented on GitHub (Feb 16, 2026): > Thanks for the fix! This seems to fix my missing drive as well: Are you saying the script never found the WUH721816ALE6L4 drive(s) before or it did but the drive still showed as unverfied?

kerem commented 2026-03-07 19:17:02 +03:00

Author

Owner

Copy link

@francoism90 commented on GitHub (Feb 16, 2026):

@007revad That's a good question, I cannot remember if it before. Is there any way to check this?

$ m="$(cat /sys/block/sata1/device/model)"; echo "'$m'"
'WD80EDBZ-11B0ZA0        '
$ m="$(cat /sys/block/sata2/device/model)"; echo "'$m'"
'WDC  WUH721816ALE6L4    '
$ m="$(cat /sys/block/sata3/device/model)"; echo "'$m'"
'WD80EDAZ-11TA3A0        '
$ m="$(cat /sys/block/sata4/device/model)"; echo "'$m'"
'WD80EDAZ-11TA3A0        '   

<!-- gh-comment-id:3908057828 --> @francoism90 commented on GitHub (Feb 16, 2026): @007revad That's a good question, I cannot remember if it before. Is there any way to check this? ```bash $ m="$(cat /sys/block/sata1/device/model)"; echo "'$m'" 'WD80EDBZ-11B0ZA0 ' $ m="$(cat /sys/block/sata2/device/model)"; echo "'$m'" 'WDC WUH721816ALE6L4 ' $ m="$(cat /sys/block/sata3/device/model)"; echo "'$m'" 'WD80EDAZ-11TA3A0 ' $ m="$(cat /sys/block/sata4/device/model)"; echo "'$m'" 'WD80EDAZ-11TA3A0 ' ```

kerem commented 2026-03-07 19:17:02 +03:00

Author

Owner

Copy link

@007revad commented on GitHub (Feb 19, 2026):

I see the problem.

$ m="$(cat /sys/block/sata2/device/model)"; echo "'$m'"
'WDC  WUH721816ALE6L4    '

In v3.6.121 and older the script used to:

1. Remove all spaces before and after the model name.
2. Replace multiple spaces in the model name with a single space.
3. Remove WDC from start of any model name that included WDC (note the single space after WDC).

In v3.6.122 the script does not do step 2. So because your "WDC " has 2 spaces after the WDC step 3 is not removing the remaining leading space.

Can you try https://github.com/007revad/Synology_HDD_db/releases/tag/v3.6.123 and confirm it fixes the issue.

<!-- gh-comment-id:3930065194 --> @007revad commented on GitHub (Feb 19, 2026): I see the problem. ``` $ m="$(cat /sys/block/sata2/device/model)"; echo "'$m'" 'WDC WUH721816ALE6L4 ' ``` In v3.6.121 and older the script used to: 1. Remove all spaces before and after the model name. 2. Replace multiple spaces in the model name with a single space. 3. Remove `WDC ` from start of any model name that included `WDC ` (note the single space after WDC). In v3.6.122 the script does not do step 2. So because your "`WDC `" has 2 spaces after the WDC step 3 is not removing the remaining leading space. Can you try https://github.com/007revad/Synology_HDD_db/releases/tag/v3.6.123 and confirm it fixes the issue.

kerem commented 2026-03-07 19:17:02 +03:00

Author

Owner

Copy link

@francoism90 commented on GitHub (Feb 19, 2026):

@007revad I'll report back late this weekend, thanks for looking into it. :)

<!-- gh-comment-id:3930090843 --> @francoism90 commented on GitHub (Feb 19, 2026): @007revad I'll report back late this weekend, thanks for looking into it. :)

kerem referenced this issue 2026-03-07 19:17:45 +03:00

[PR #204] [MERGED] Develop #319

kerem referenced this issue 2026-03-12 17:44:36 +03:00

[PR #204] [MERGED] Develop #979

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

test

develop

v3.6.125

v3.6.124

v3.6.123

v3.6.122

v3.6.121

v3.6.119

v3.6.118

v3.6.116

v3.6.115

v3.6.114

v3.6.113

v3.6.112

v3.6.111

v3.6.110

v3.6.109

v3.5.108

v3.5.107

v3.5.106

v3.5.105

v3.5.104

v3.5.103

v3.5.102

v3.5.101

v3.5.100-RC

v3.5.99-RC

v3.5.98

v3.5.97

v3.5.96

v3.5.94

v3.5.94-RC

v3.5.93

v3.5.92

v3.5.91

v3.5.90

v3.5.90-RC

v3.5.89

v3.5.88

v3.4.87

v3.4.86

v3.4.85

v3.4.84

v3.4.83

v3.4.82

v3.4.81

v3.4.80

v3.4.79

v3.4.78

v3.4.77

v3.3.73

v3.3.72

v3.3.70

v3.2.69

v3.2.68

v3.2.67-RC

v3.2.66-RC

v3.1.65

v3.1.64

v3.1.63

v3.1.62

v3.1.61

v3.1.60-RC

v3.1.59-RC

v3.1.58-RC

v3.1.57-RC

v3.0.56

v3.0.55

v2.3.54-RC

v2.3.51-RC

v2.3.49-RC

v2.3.48-RC

v2.2.47

v2.3.53-RC

v2.3.50-RC

v2.2.46

get_syno_model

v2.2.46_test

v2.2.45

v2.2.44

v2.2.43

v2.2.42

v2.2.39

v2.2.40

v2.2.41

v2.1.38

v2.1.37

v2.0.35

v1.3.34

v1.3.33

v1.3.32

v1.2.31

v1.2.30

v1.2.29

v1.2.28

v1.2.27

v1.2.25

v1.2.26

v1.2.24

v1.2.23

v1.2.22

v1.2.21

v1.2.20

v1.2.17

v1.2.16

v1.2.15

v1.1.14

v1.1.13

v1.1.12

v1.1.11

1.1.10

v1.1.9

1.1.8

v1.0.7

V1.0.6

v1.0.5

v1.0.4

v1.0.3

v1.0.2

v1.0.1

v1.0.0

Labels

Clear labels   

bug

  

bug

  

bug

  

documentation

  

enhancement

  

enhancement

  

help wanted

  

pull-request

Mirrored from GitHub Pull Request

  

suggestion

No labels

bug

bug

bug

documentation

enhancement

enhancement

help wanted

pull-request

suggestion

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/Synology_HDD_db#204

No description provided.