[PR #58] [CLOSED] Added some fixes to version 2.7.0 to further improve performance #95

New issue

Closed

opened 2026-02-25 21:30:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:30:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/brutaldev/StrongNameSigner/pull/58
Author: @programatix
Created: 12/12/2019
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (2)

70603f6 Added a path to Microsoft Framework assemblies to the ignored path check.
bbeb7ba Update AutomaticBuildTask.cs

📊 Changes

1 file changed (+14 additions, -13 deletions)

View changed files

📝 src/Brutal.Dev.StrongNameSigner/AutomaticBuildTask.cs (+14 -13)

📄 Description

Version 2.7.0 doesn't fix the issue I'm having. Checking the msbuild binary log, it seems that there is another path of Microsoft Framework assemblies that are being processed which it should not (as intended by the update done to version 2.7.0). I added the path to the exclude list.

Also I noted that assemblies that are originally signed being processed again and again by StrongNameSigner. This update removed them from being processed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/brutaldev/StrongNameSigner/pull/58 **Author:** [@programatix](https://github.com/programatix) **Created:** 12/12/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`70603f6`](https://github.com/brutaldev/StrongNameSigner/commit/70603f6519b38b369154edc2a0292f7fc8e8fc56) Added a path to Microsoft Framework assemblies to the ignored path check. - [`bbeb7ba`](https://github.com/brutaldev/StrongNameSigner/commit/bbeb7ba411d83b83f2dd533a4314c7d84bd06f49) Update AutomaticBuildTask.cs ### 📊 Changes **1 file changed** (+14 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/Brutal.Dev.StrongNameSigner/AutomaticBuildTask.cs` (+14 -13) </details> ### 📄 Description This is related to https://github.com/brutaldev/StrongNameSigner/issues/57. Version 2.7.0 doesn't fix the issue I'm having. Checking the msbuild binary log, it seems that there is another path of Microsoft Framework assemblies that are being processed which it should not (as intended by the update done to version 2.7.0). I added the path to the exclude list. Also I noted that assemblies that are originally signed being processed again and again by StrongNameSigner. This update removed them from being processed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>