[PR #22] [CLOSED] Refactor the code so that the UI and the Console version share more logic. #93

New issue

Closed

opened 2026-02-25 21:30:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:30:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/brutaldev/StrongNameSigner/pull/22
Author: @bradphelan
Created: 4/26/2016
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (7)

b68eb2e Add editorconfig for the EditorConfig Visual Studio plugin
349ba7a Do not write assemblies until the end.
ed15916 Refactor the code into an easier to understand logic.
b35c292 don't perform copy if the source is the same as the target
63e64ed add read and write debug symbols
3bf5f33 remove leading slashes if they occur
bd1db59 add copy of pdb files if they exist

📊 Changes

19 files changed (+588 additions, -601 deletions)

View changed files

➕ .editorconfig (+12 -0)
📝 src/Brutal.Dev.StrongNameSigner.Console/Brutal.Dev.StrongNameSigner.Console.csproj (+16 -1)
➖ src/Brutal.Dev.StrongNameSigner.Console/LogLevel.cs (+0 -13)
📝 src/Brutal.Dev.StrongNameSigner.Console/Options.cs (+1 -1)
📝 src/Brutal.Dev.StrongNameSigner.Console/Program.cs (+19 -190)
📝 src/Brutal.Dev.StrongNameSigner.Console/packages.config (+1 -0)
📝 src/Brutal.Dev.StrongNameSigner.Setup/scripts/isxdl/czech.ini (+53 -53)
📝 src/Brutal.Dev.StrongNameSigner.Tests/Brutal.Dev.StrongNameSigner.Tests.csproj (+1 -0)
📝 src/Brutal.Dev.StrongNameSigner.Tests/FixAssemblyReferenceTests.cs (+7 -2)
📝 src/Brutal.Dev.StrongNameSigner.Tests/GetAssemblyInfoTests.cs (+1 -0)
📝 src/Brutal.Dev.StrongNameSigner.UI/Brutal.Dev.StrongNameSigner.UI.csproj (+1 -0)
📝 src/Brutal.Dev.StrongNameSigner.UI/MainForm.Designer.cs (+1 -1)
📝 src/Brutal.Dev.StrongNameSigner.UI/MainForm.cs (+15 -105)
➕ src/Brutal.Dev.StrongNameSigner/AssemblyCollection.cs (+87 -0)
➕ src/Brutal.Dev.StrongNameSigner/AssemblyHolder.cs (+215 -0)
📝 src/Brutal.Dev.StrongNameSigner/Brutal.Dev.StrongNameSigner.csproj (+5 -0)
➕ src/Brutal.Dev.StrongNameSigner/LogLevel.cs (+11 -0)
📝 src/Brutal.Dev.StrongNameSigner/SigningHelper.cs (+133 -235)
➕ src/Brutal.Dev.StrongNameSigner/Stats.cs (+9 -0)

📄 Description

I created AssemblyCollection and AssemblyHolder to unify all the shared logic in the UI and the console versions. Logging is now an inject-able dependency that is different in the UI and console versions.

The code should also be much faster as it doesn't write and read the assemblies as often, especially in the loop where the references are updated. I save and sign all the assemblies at the end.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/brutaldev/StrongNameSigner/pull/22 **Author:** [@bradphelan](https://github.com/bradphelan) **Created:** 4/26/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`b68eb2e`](https://github.com/brutaldev/StrongNameSigner/commit/b68eb2e657220f84064fe92e5385066d05f151e3) Add editorconfig for the EditorConfig Visual Studio plugin - [`349ba7a`](https://github.com/brutaldev/StrongNameSigner/commit/349ba7ae639cb28e3962087359cb3585a8ccae4c) Do not write assemblies until the end. - [`ed15916`](https://github.com/brutaldev/StrongNameSigner/commit/ed159165c31720010320b21d17ec5efc91e6c3c9) Refactor the code into an easier to understand logic. - [`b35c292`](https://github.com/brutaldev/StrongNameSigner/commit/b35c292a860d5877a8d95ce59b01fca63880d54c) don't perform copy if the source is the same as the target - [`63e64ed`](https://github.com/brutaldev/StrongNameSigner/commit/63e64ed710ebb41ea80469188c527a1360780f37) add read and write debug symbols - [`3bf5f33`](https://github.com/brutaldev/StrongNameSigner/commit/3bf5f3338f96081777d8928ef2fe4be4ce06c590) remove leading slashes if they occur - [`bd1db59`](https://github.com/brutaldev/StrongNameSigner/commit/bd1db594408571d6547561e7811d4fab339eb9ef) add copy of pdb files if they exist ### 📊 Changes **19 files changed** (+588 additions, -601 deletions) <details> <summary>View changed files</summary> ➕ `.editorconfig` (+12 -0) 📝 `src/Brutal.Dev.StrongNameSigner.Console/Brutal.Dev.StrongNameSigner.Console.csproj` (+16 -1) ➖ `src/Brutal.Dev.StrongNameSigner.Console/LogLevel.cs` (+0 -13) 📝 `src/Brutal.Dev.StrongNameSigner.Console/Options.cs` (+1 -1) 📝 `src/Brutal.Dev.StrongNameSigner.Console/Program.cs` (+19 -190) 📝 `src/Brutal.Dev.StrongNameSigner.Console/packages.config` (+1 -0) 📝 `src/Brutal.Dev.StrongNameSigner.Setup/scripts/isxdl/czech.ini` (+53 -53) 📝 `src/Brutal.Dev.StrongNameSigner.Tests/Brutal.Dev.StrongNameSigner.Tests.csproj` (+1 -0) 📝 `src/Brutal.Dev.StrongNameSigner.Tests/FixAssemblyReferenceTests.cs` (+7 -2) 📝 `src/Brutal.Dev.StrongNameSigner.Tests/GetAssemblyInfoTests.cs` (+1 -0) 📝 `src/Brutal.Dev.StrongNameSigner.UI/Brutal.Dev.StrongNameSigner.UI.csproj` (+1 -0) 📝 `src/Brutal.Dev.StrongNameSigner.UI/MainForm.Designer.cs` (+1 -1) 📝 `src/Brutal.Dev.StrongNameSigner.UI/MainForm.cs` (+15 -105) ➕ `src/Brutal.Dev.StrongNameSigner/AssemblyCollection.cs` (+87 -0) ➕ `src/Brutal.Dev.StrongNameSigner/AssemblyHolder.cs` (+215 -0) 📝 `src/Brutal.Dev.StrongNameSigner/Brutal.Dev.StrongNameSigner.csproj` (+5 -0) ➕ `src/Brutal.Dev.StrongNameSigner/LogLevel.cs` (+11 -0) 📝 `src/Brutal.Dev.StrongNameSigner/SigningHelper.cs` (+133 -235) ➕ `src/Brutal.Dev.StrongNameSigner/Stats.cs` (+9 -0) </details> ### 📄 Description I created AssemblyCollection and AssemblyHolder to unify all the shared logic in the UI and the console versions. Logging is now an inject-able dependency that is different in the UI and console versions. The code should also be much faster as it doesn't write and read the assemblies as often, especially in the loop where the references are updated. I save and sign all the assemblies at the end. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>