mirror of
https://github.com/brutaldev/StrongNameSigner.git
synced 2026-04-25 11:26:04 +03:00
[GH-ISSUE #101] Failure to sign due to FIPS does not return an error #82
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @brettshearer on GitHub (Mar 29, 2025).
Original GitHub issue: https://github.com/brutaldev/StrongNameSigner/issues/101
Originally assigned to: @brutaldev on GitHub.
When FIPS is enabled the following error is shown in logs:
==== signing WeakEventListener.dll ====
---- Brutal Developer .NET Assembly Strong-Name Signer 3.5.0.0 ----
Console application to sign .NET assemblies with a strong-name key and fix assembly references.
Checking assembly references in 'c:\git\wtg\CargoWise\Dev\packages\SimpleWeakEventListener\lib\netstandard2.0\WeakEventListener.dll'.
Signing assembly 'c:\git\wtg\CargoWise\Dev\packages\SimpleWeakEventListener\lib\netstandard2.0\WeakEventListener.dll'.
Saving changes to assembly 'c:\git\wtg\CargoWise\Dev\packages\SimpleWeakEventListener\lib\netstandard2.0\WeakEventListener.dll'.
Failed to save assembly 'c:\git\wtg\CargoWise\Dev\packages\SimpleWeakEventListener\lib\netstandard2.0\WeakEventListener.dll': This implementation is not part of the Windows Platform FIPS validated cryptographic algorithms.
This is our usage:
echo ==== signing WeakEventListener.dll ====
.\packages\Brutal.Dev.StrongNameSigner\build\StrongNameSigner.Console.exe -a .\packages\SimpleWeakEventListener\lib\netstandard2.0\WeakEventListener.dll -out .\packages\SimpleWeakEventListener\lib\netstandard2.0
if %errorlevel% neq 0 goto :end
If the file is missing completely, we get an error code.
I would expect that a failure to sign should also raise an error code.
@brutaldev commented on GitHub (Mar 30, 2025):
Should be fixed up in v3.5.1
I have also added an error code for any signing failure in the core, even if other operations succeed. Any non-warning errors have always returned a non-zero error code.