mirror of
https://github.com/brutaldev/StrongNameSigner.git
synced 2026-04-25 11:26:04 +03:00
[GH-ISSUE #36] New Variable to locate StrongNameSigner #33
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tomap on GitHub (May 11, 2017).
Original GitHub issue: https://github.com/brutaldev/StrongNameSigner/issues/36
Originally assigned to: @tomap, @brutaldev on GitHub.
Hi,
Could you add a new variable here to locate StrongNameSigner?
Here:
https://github.com/brutaldev/StrongNameSigner/blob/master/src/Brutal.Dev.StrongNameSigner/StrongNameSigner.targets#L20
You could declare
<StrongNameSignerDirectory>$(MSBuildThisFileDirectory)</StrongNameSignerDirectory>So that from pre / post build step, we can use this variable to find Brutal.Dev.StrongNameSigner console and not hardcode the path containing the version (curerntly Brutal.Dev.StrongNameSigner.2.1.2)
Thank you
@brutaldev commented on GitHub (May 11, 2017):
Hey @tomap
I wouldn't even know where to start or how to test that. My MSBuild skills are sketchy at best so if you could submit a PR with an example of how to make use of it I'll happily accept and release another build.
@tomap commented on GitHub (May 11, 2017):
Done, see https://github.com/brutaldev/StrongNameSigner/pull/37
@brutaldev commented on GitHub (May 11, 2017):
Awesome, thanks! Just did some reading and that's pretty useful, it is a pain updating the version each time for me as well so I'll make use this... Will merge and release in a couple of hours when I get back on my dev machine.
@brutaldev commented on GitHub (May 12, 2017):
Released the changes: https://github.com/brutaldev/StrongNameSigner/releases/tag/v2.1.3