[GH-ISSUE #36] New Variable to locate StrongNameSigner #33

Closed
opened 2026-02-25 21:30:30 +03:00 by kerem · 4 comments
Owner

Originally created by @tomap on GitHub (May 11, 2017).
Original GitHub issue: https://github.com/brutaldev/StrongNameSigner/issues/36

Originally assigned to: @tomap, @brutaldev on GitHub.

Hi,

Could you add a new variable here to locate StrongNameSigner?
Here:
https://github.com/brutaldev/StrongNameSigner/blob/master/src/Brutal.Dev.StrongNameSigner/StrongNameSigner.targets#L20

You could declare
<StrongNameSignerDirectory>$(MSBuildThisFileDirectory)</StrongNameSignerDirectory>

So that from pre / post build step, we can use this variable to find Brutal.Dev.StrongNameSigner console and not hardcode the path containing the version (curerntly Brutal.Dev.StrongNameSigner.2.1.2)

Thank you

Originally created by @tomap on GitHub (May 11, 2017). Original GitHub issue: https://github.com/brutaldev/StrongNameSigner/issues/36 Originally assigned to: @tomap, @brutaldev on GitHub. Hi, Could you add a new variable here to locate StrongNameSigner? Here: https://github.com/brutaldev/StrongNameSigner/blob/master/src/Brutal.Dev.StrongNameSigner/StrongNameSigner.targets#L20 You could declare `<StrongNameSignerDirectory>$(MSBuildThisFileDirectory)</StrongNameSignerDirectory>` So that from pre / post build step, we can use this variable to find Brutal.Dev.StrongNameSigner console and not hardcode the path containing the version (curerntly Brutal.Dev.StrongNameSigner.2.1.2) Thank you
kerem 2026-02-25 21:30:30 +03:00
Author
Owner

@brutaldev commented on GitHub (May 11, 2017):

Hey @tomap
I wouldn't even know where to start or how to test that. My MSBuild skills are sketchy at best so if you could submit a PR with an example of how to make use of it I'll happily accept and release another build.

<!-- gh-comment-id:300782534 --> @brutaldev commented on GitHub (May 11, 2017): Hey @tomap I wouldn't even know where to start or how to test that. My MSBuild skills are sketchy at best so if you could submit a PR with an example of how to make use of it I'll happily accept and release another build.
Author
Owner

@tomap commented on GitHub (May 11, 2017):

Done, see https://github.com/brutaldev/StrongNameSigner/pull/37

<!-- gh-comment-id:300785773 --> @tomap commented on GitHub (May 11, 2017): Done, see https://github.com/brutaldev/StrongNameSigner/pull/37
Author
Owner

@brutaldev commented on GitHub (May 11, 2017):

Awesome, thanks! Just did some reading and that's pretty useful, it is a pain updating the version each time for me as well so I'll make use this... Will merge and release in a couple of hours when I get back on my dev machine.

<!-- gh-comment-id:300788533 --> @brutaldev commented on GitHub (May 11, 2017): Awesome, thanks! Just did some reading and that's pretty useful, it is a pain updating the version each time for me as well so I'll make use this... Will merge and release in a couple of hours when I get back on my dev machine.
Author
Owner

@brutaldev commented on GitHub (May 12, 2017):

Released the changes: https://github.com/brutaldev/StrongNameSigner/releases/tag/v2.1.3

<!-- gh-comment-id:301190209 --> @brutaldev commented on GitHub (May 12, 2017): Released the changes: https://github.com/brutaldev/StrongNameSigner/releases/tag/v2.1.3
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/StrongNameSigner#33
No description provided.