[PR #85] [MERGED] fix: Updating custom attributes with type reference arguments #107

New issue

Closed

opened 2026-02-25 21:30:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:30:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/brutaldev/StrongNameSigner/pull/85
Author: @nickrandolph
Created: 1/12/2023
Status: ✅ Merged
Merged: 1/12/2023
Merged by: @brutaldev

Base: master ← Head: dev/nr/fixcustomattribute

📝 Commits (2)

53fa5af fix: Updating custom attributes with type reference arguments
8bf83f9 fix: Removing internalvisibleto attributes that don't have a strong name

📊 Changes

1 file changed (+54 additions, -11 deletions)

View changed files

📝 src/Brutal.Dev.StrongNameSigner/SigningHelper.cs (+54 -11)

📄 Description

One of the assemblies we're signing has a custom attribute that references a type in another of the assemblies to be signed. This custom attribute isn't currently being updated to look for the signed assembly

eg
[MyCustomAttribute(typeof(TypeFromUnsignedAssembly))]

This PR also adds back logic for removing InternalVisibleTo attributes that can't be fully resolved ie the assembly isn't in the list of assemblies to be signed, and doesn't have a strong name

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/brutaldev/StrongNameSigner/pull/85 **Author:** [@nickrandolph](https://github.com/nickrandolph) **Created:** 1/12/2023 **Status:** ✅ Merged **Merged:** 1/12/2023 **Merged by:** [@brutaldev](https://github.com/brutaldev) **Base:** `master` ← **Head:** `dev/nr/fixcustomattribute` --- ### 📝 Commits (2) - [`53fa5af`](https://github.com/brutaldev/StrongNameSigner/commit/53fa5af022b6deb087cfa11170e2b6ac26bd748c) fix: Updating custom attributes with type reference arguments - [`8bf83f9`](https://github.com/brutaldev/StrongNameSigner/commit/8bf83f909babc659752df967fc052cd135b6cbe3) fix: Removing internalvisibleto attributes that don't have a strong name ### 📊 Changes **1 file changed** (+54 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/Brutal.Dev.StrongNameSigner/SigningHelper.cs` (+54 -11) </details> ### 📄 Description One of the assemblies we're signing has a custom attribute that references a type in another of the assemblies to be signed. This custom attribute isn't currently being updated to look for the signed assembly eg [MyCustomAttribute(typeof(TypeFromUnsignedAssembly))] This PR also adds back logic for removing InternalVisibleTo attributes that can't be fully resolved ie the assembly isn't in the list of assemblies to be signed, and doesn't have a strong name --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>