[PR #84] [MERGED] fix: Correcting task order default values #105

New issue

Closed

opened 2026-02-25 21:30:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:30:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/brutaldev/StrongNameSigner/pull/84
Author: @nickrandolph
Created: 1/10/2023
Status: ✅ Merged
Merged: 1/10/2023
Merged by: @brutaldev

Base: master ← Head: dev/nr/taskorderfix

📝 Commits (1)

0233d93 fix: Correcting task order default values

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 src/Brutal.Dev.StrongNameSigner/StrongNameSigner.targets (+4 -4)

📄 Description

The original version enforced signing happening before CoreCompile, which doesn't work for our scenario where we need to completely override the default values. This update allows the StrongNameSignerBeforeTargets and StrongNameSignerAfterTargets to be defined in the csproj without it being overwritten by the targets file in this package

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/brutaldev/StrongNameSigner/pull/84 **Author:** [@nickrandolph](https://github.com/nickrandolph) **Created:** 1/10/2023 **Status:** ✅ Merged **Merged:** 1/10/2023 **Merged by:** [@brutaldev](https://github.com/brutaldev) **Base:** `master` ← **Head:** `dev/nr/taskorderfix` --- ### 📝 Commits (1) - [`0233d93`](https://github.com/brutaldev/StrongNameSigner/commit/0233d93575afac89c179a0e3b417de8aed5c6cd6) fix: Correcting task order default values ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/Brutal.Dev.StrongNameSigner/StrongNameSigner.targets` (+4 -4) </details> ### 📄 Description The original version enforced signing happening before CoreCompile, which doesn't work for our scenario where we need to completely override the default values. This update allows the StrongNameSignerBeforeTargets and StrongNameSignerAfterTargets to be defined in the csproj without it being overwritten by the targets file in this package --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>